Fix undetected broken tests because of missing dependencies#8050
Merged
Fix undetected broken tests because of missing dependencies#8050
Conversation
4021017 to
44a264a
Compare
entantoencuanto
added a commit
that referenced
this pull request
May 31, 2021
* develop: (59 commits) Update supported versions in docs (#8079) Meetings merge minutes and close actions (#7968) Meeting calendars providers (#7944) Fix broken test on meetings after merging PR without rebase (#8076) Show participants list in meetings (#7933) Security feature external link warning (#7397) Add missing tests for scope types admin page (#8053) Use symbols for polymorphic route arguments (#8052) Mockup design for Participation statistics tables in Votings (#7879) Fix boolean fields for .reported? and .hidden? which is nil if no report exists (#7990) Fix redirects broken by Terms and Conditions redirect (#8036) Amend CSS overwritting (#8007) New Crowdin updates (#8048) Fix undetected broken tests because of missing dependencies (#8050) Validate results by Monitoring Committee Members (#7899) Electoral certificate validation by Monitoring Committee Members (#7871) Publish and unpublish a meeting (#7893) New Crowdin updates (#8005) Polling station closure attach the physical electoral closure certificate (#7929) Fix attachment title migration generating possibly invalid values (#8020) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
After merging the PR #7893 two tests started to fail. This was because there were some missing dependencies between modules, so after some changes in the
decidim-meetingsmodule, not all the affected tests were executed.On one hand, there is a dev dependency from
decidim-participatory_processestodecidim-meetings. This problem was easily fixed adding the dependency to the.gemspecfile.The other dependency is a bit trickier. There is a dev dependency from
decidim-coreto many other modules (accountability, elections, meetings, proposals) to run the open data tests. In this case, add those dev dependencies todecidim-corewould force all PRs to run almost all the tests. So, in this case, I just fixed the broken test, and we will have to move these tests to each module, to eliminate the need to add those dependencies.📌 Related Issues