Skip to content

Show confirmation modal when leaving a meeting#7970

Merged
mrcasals merged 3 commits intodecidim:developfrom
Platoniq:feat/leave-meeting-confirmation
May 10, 2021
Merged

Show confirmation modal when leaving a meeting#7970
mrcasals merged 3 commits intodecidim:developfrom
Platoniq:feat/leave-meeting-confirmation

Conversation

@aitorlb
Copy link
Copy Markdown
Contributor

@aitorlb aitorlb commented May 8, 2021

🎩 What? Why?

In the process of registering the meeting in Decidim, a button is generated where the user has the option to join. If you click the same button again, the user desjoin from the meeting. Because only one click is required, users sometimes inadvertently withdraw their registration.

📌 Related Issues

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Peek.2021-05-08.17-54.mp4

♥️ Thank you!

@mrcasals
Copy link
Copy Markdown
Contributor

Yay, nice one! Thanks!

@mrcasals mrcasals merged commit 0d90545 into decidim:develop May 10, 2021
entantoencuanto added a commit that referenced this pull request May 12, 2021
…ions

* develop: (23 commits)
  New Crowdin updates (#8001)
  Fix editor when formatting starts with a linebreak (#7999)
  Polling station officer ballot count (#7823)
  New Crowdin updates (#7995)
  Election log (#7923)
  New Crowdin updates (#7988)
  Fixing failing tests on develop branch (#7991)
  Add notes to changelog (#7987)
  Add 2 additional queues for a better scalling of the application (#7986)
  Add announcements to assemblies (#7971)
  Display meetings count in directory page (#7972)
  Touch the reportable object when is hidden to reset caches (#7966)
  Hide moderated meetings and proposals from admin lists (#7974)
  Hide moderated proposals from comparator (#7975)
  Add comment count to the proposal cache (#7965)
  Simplify SQL query for endorsement stats (#7973)
  Show confirmation modal when leaving a meeting (#7970)
  Fix: #7889 - Each comment in a meeting generates a new version of the meeting (#7978)
  Add cache layer for ActivityCell boxes (#7967)
  New Crowdin updates (#7980)
  ...
microstudi added a commit to Platoniq/decidim that referenced this pull request May 14, 2021
* Show confirmation modal when leaving a meeting

* Update specs

* Update spec
# Conflicts:
#	decidim-meetings/spec/system/meeting_registrations_spec.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants