Skip to content

Add 2 additional queues for a better scalling of the application#7986

Merged
mrcasals merged 2 commits intodecidim:developfrom
i-need-another-coffee:ale-split-queues
May 10, 2021
Merged

Add 2 additional queues for a better scalling of the application#7986
mrcasals merged 2 commits intodecidim:developfrom
i-need-another-coffee:ale-split-queues

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

This PR set 2 new queues on ActiveJob level to help out scaling.
The Queues are:

  • translations, which in case of many languages being supported generates a lot of jobs that may perform http requests to fetch new data
  • exports, which can be very lengthy operations and may require its own sidekiq instance.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

Copy link
Copy Markdown
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me!

@mrcasals mrcasals merged commit 008c3ea into decidim:develop May 10, 2021
@alecslupu alecslupu deleted the ale-split-queues branch May 10, 2021 15:40
entantoencuanto added a commit that referenced this pull request May 12, 2021
…ions

* develop: (23 commits)
  New Crowdin updates (#8001)
  Fix editor when formatting starts with a linebreak (#7999)
  Polling station officer ballot count (#7823)
  New Crowdin updates (#7995)
  Election log (#7923)
  New Crowdin updates (#7988)
  Fixing failing tests on develop branch (#7991)
  Add notes to changelog (#7987)
  Add 2 additional queues for a better scalling of the application (#7986)
  Add announcements to assemblies (#7971)
  Display meetings count in directory page (#7972)
  Touch the reportable object when is hidden to reset caches (#7966)
  Hide moderated meetings and proposals from admin lists (#7974)
  Hide moderated proposals from comparator (#7975)
  Add comment count to the proposal cache (#7965)
  Simplify SQL query for endorsement stats (#7973)
  Show confirmation modal when leaving a meeting (#7970)
  Fix: #7889 - Each comment in a meeting generates a new version of the meeting (#7978)
  Add cache layer for ActivityCell boxes (#7967)
  New Crowdin updates (#7980)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants