Skip to content

Add announcements to assemblies#7971

Merged
mrcasals merged 1 commit intodevelopfrom
feat/assemblies-announcements
May 10, 2021
Merged

Add announcements to assemblies#7971
mrcasals merged 1 commit intodevelopfrom
feat/assemblies-announcements

Conversation

@ferblape
Copy link
Copy Markdown
Contributor

@ferblape ferblape commented May 9, 2021 •
edited
Loading

🎩 What? Why?

This PR allows to add announcements to assemblies

📌 Related Issues

Testing

  • As an admin should be able to see a field in the assemblies form to add an announcement
  • As an admin the announcement should be copied when you duplicate an assembly
  • That announcement should be visible in the public view of the assembly
  • That announcement should be visible in the API

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing

Screenshot from 2021-05-10 06-20-59

Screenshot from 2021-05-10 06-21-15

♥️ Thank you!

@ferblape ferblape force-pushed the feat/assemblies-announcements branch from 4013968 to f9964c0 Compare May 9, 2021 05:36
@ferblape ferblape linked an issue May 9, 2021 that may be closed by this pull request
Add announcement in the Assembly space #7295
Closed
2 tasks
@ferblape ferblape marked this pull request as ready for review May 10, 2021 04:21
@ferblape ferblape requested a review from mrcasals May 10, 2021 04:22
@mrcasals mrcasals merged commit b86b509 into develop May 10, 2021
@mrcasals mrcasals deleted the feat/assemblies-announcements branch May 10, 2021 13:32
entantoencuanto added a commit that referenced this pull request May 12, 2021
@entantoencuanto
Merge branch 'develop' into 7285-meetings-merge-minutes-and-close-act…
7e77c42 
…ions

* develop: (23 commits)
  New Crowdin updates (#8001)
  Fix editor when formatting starts with a linebreak (#7999)
  Polling station officer ballot count (#7823)
  New Crowdin updates (#7995)
  Election log (#7923)
  New Crowdin updates (#7988)
  Fixing failing tests on develop branch (#7991)
  Add notes to changelog (#7987)
  Add 2 additional queues for a better scalling of the application (#7986)
  Add announcements to assemblies (#7971)
  Display meetings count in directory page (#7972)
  Touch the reportable object when is hidden to reset caches (#7966)
  Hide moderated meetings and proposals from admin lists (#7974)
  Hide moderated proposals from comparator (#7975)
  Add comment count to the proposal cache (#7965)
  Simplify SQL query for endorsement stats (#7973)
  Show confirmation modal when leaving a meeting (#7970)
  Fix: #7889 - Each comment in a meeting generates a new version of the meeting (#7978)
  Add cache layer for ActivityCell boxes (#7967)
  New Crowdin updates (#7980)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mrcasals mrcasals mrcasals approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: assemblies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add announcement in the Assembly space

2 participants

@ferblape @mrcasals