Add comment count to the proposal cache#7965
Merged
mrcasals merged 1 commit intodecidim:developfrom May 10, 2021
Merged
Conversation
mrcasals
approved these changes
May 10, 2021
entantoencuanto
added a commit
that referenced
this pull request
May 12, 2021
…ions * develop: (23 commits) New Crowdin updates (#8001) Fix editor when formatting starts with a linebreak (#7999) Polling station officer ballot count (#7823) New Crowdin updates (#7995) Election log (#7923) New Crowdin updates (#7988) Fixing failing tests on develop branch (#7991) Add notes to changelog (#7987) Add 2 additional queues for a better scalling of the application (#7986) Add announcements to assemblies (#7971) Display meetings count in directory page (#7972) Touch the reportable object when is hidden to reset caches (#7966) Hide moderated meetings and proposals from admin lists (#7974) Hide moderated proposals from comparator (#7975) Add comment count to the proposal cache (#7965) Simplify SQL query for endorsement stats (#7973) Show confirmation modal when leaving a meeting (#7970) Fix: #7889 - Each comment in a meeting generates a new version of the meeting (#7978) Add cache layer for ActivityCell boxes (#7967) New Crowdin updates (#7980) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR adds the comment count to the proposal cache key, to ensure the cache is being expired when a new comment is being added.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
