Skip to content

Hide moderated meetings and proposals from admin lists#7974

Merged
mrcasals merged 1 commit intodecidim:developfrom
i-need-another-coffee:fix/7429
May 10, 2021
Merged

Hide moderated meetings and proposals from admin lists#7974
mrcasals merged 1 commit intodecidim:developfrom
i-need-another-coffee:fix/7429

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented May 9, 2021

🎩 What? Why?

When a meeting or a proposal is being hidden, the specific resources are still being displayed in the admin section. This Pr aims to hide them from the resource admin section . This PR adds the functionality only for Proposals and Meeting, letting other components untouched.

Need to add test for the scenario

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@alecslupu alecslupu marked this pull request as ready for review May 10, 2021 13:07
@mrcasals mrcasals added module: meetings module: proposals type: fix PRs that implement a fix for a bug labels May 10, 2021
@mrcasals mrcasals changed the title Fix: #7429 - Moderated content displayed in resource index Hide moderated meetings and proposals from admin lists May 10, 2021
@mrcasals mrcasals merged commit f402efc into decidim:develop May 10, 2021
entantoencuanto added a commit that referenced this pull request May 12, 2021
…ions

* develop: (23 commits)
  New Crowdin updates (#8001)
  Fix editor when formatting starts with a linebreak (#7999)
  Polling station officer ballot count (#7823)
  New Crowdin updates (#7995)
  Election log (#7923)
  New Crowdin updates (#7988)
  Fixing failing tests on develop branch (#7991)
  Add notes to changelog (#7987)
  Add 2 additional queues for a better scalling of the application (#7986)
  Add announcements to assemblies (#7971)
  Display meetings count in directory page (#7972)
  Touch the reportable object when is hidden to reset caches (#7966)
  Hide moderated meetings and proposals from admin lists (#7974)
  Hide moderated proposals from comparator (#7975)
  Add comment count to the proposal cache (#7965)
  Simplify SQL query for endorsement stats (#7973)
  Show confirmation modal when leaving a meeting (#7970)
  Fix: #7889 - Each comment in a meeting generates a new version of the meeting (#7978)
  Add cache layer for ActivityCell boxes (#7967)
  New Crowdin updates (#7980)
  ...
@alecslupu alecslupu deleted the fix/7429 branch July 19, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: meetings module: proposals type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moderated content displayed in resource index

2 participants