update to latest #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also output covered | total lines, and a summary percentage at the end + Kick tree
…the specified Rect is already visible. (flutter#56413)" (flutter#64091) This reverts commit 64d76f2.
…ter#63599)" (flutter#64094) This reverts commit 1de673b.
… the focus by default (flutter#63592) Focus will be moved automatically if onEditingComplete is not specified, but must by moved manually if onEditingComplete is specified.
…tter#64071)" (flutter#64118) This reverts commit acdb909.
darshankawar
pushed a commit
that referenced
this pull request
Sep 8, 2021
…1498)" (flutter#71519) This appears to be triggering an null dereference by calling popSystemNavigator on a null platform plugin delegate. boolean io.flutter.plugin.platform.PlatformPlugin$PlatformPluginDelegate.popSystemNavigator() Relevant logs: ``` 2020-12-01T14:34:34.410242: stderr: [ +6 ms] VMServiceFlutterDriver: >>> {command: get_text, finderType: ByValueKey, keyValueString: status, keyValueType: String} 2020-12-01T14:34:34.490211: stderr: [ +79 ms] VMServiceFlutterDriver: <<< {isError: false, response: {text: ok}, type: _extensionType, method: ext.flutter.driver} 2020-12-01T14:34:34.493011: stderr: [ +2 ms] VMServiceFlutterDriver: >>> {command: tap, finderType: ByValueKey, keyValueString: step, keyValueType: String} 2020-12-01T14:34:34.962001: stdout: [ +468 ms] E/MethodChannel#flutter/platform( 9732): Failed to handle method call 2020-12-01T14:34:34.962222: stdout: [ ] E/MethodChannel#flutter/platform( 9732): java.lang.NullPointerException: Attempt to invoke interface method 'boolean io.flutter.plugin.platform.PlatformPlugin$PlatformPluginDelegate.popSystemNavigator()' on a null object reference 2020-12-01T14:34:34.962356: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.plugin.platform.PlatformPlugin.popSystemNavigator(PlatformPlugin.java:313) 2020-12-01T14:34:34.962499: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.plugin.platform.PlatformPlugin.access$600(PlatformPlugin.java:28) 2020-12-01T14:34:34.962735: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.plugin.platform.PlatformPlugin$1.popSystemNavigator(PlatformPlugin.java:101) 2020-12-01T14:34:34.963047: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.embedding.engine.systemchannels.PlatformChannel$1.onMethodCall(PlatformChannel.java:123) 2020-12-01T14:34:34.963284: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:233) 2020-12-01T14:34:34.963592: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.embedding.engine.dart.DartMessenger.handleMessageFromDart(DartMessenger.java:85) 2020-12-01T14:34:34.963910: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessage(FlutterJNI.java:738) 2020-12-01T14:34:34.964227: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at android.os.MessageQueue.nativePollOnce(Native Method) 2020-12-01T14:34:34.964571: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at android.os.MessageQueue.next(MessageQueue.java:323) 2020-12-01T14:34:34.964805: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at android.os.Looper.loop(Looper.java:136) 2020-12-01T14:34:34.965034: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at android.app.ActivityThread.main(ActivityThread.java:6123) 2020-12-01T14:34:34.965248: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at java.lang.reflect.Method.invoke(Native Method) 2020-12-01T14:34:34.965398: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:867) 2020-12-01T14:34:34.965589: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:757) 2020-12-01T14:34:34.966863: stderr: [ +1 ms] VMServiceFlutterDriver: <<< {isError: false, response: {}, type: _extensionType, method: ext.flutter.driver} 2020-12-01T14:34:34.967698: stderr: [ ] VMServiceFlutterDriver: >>> {command: get_text, finderType: ByValueKey, keyValueString: status, keyValueType: String} 2020-12-01T14:34:34.986399: stdout: [ +18 ms] E/flutter ( 9732): [ERROR:flutter/shell/common/shell.cc(209)] Dart Unhandled Exception: PlatformException(error, Attempt to invoke interface method 'boolean io.flutter.plugin.platform.PlatformPlugin$PlatformPluginDelegate.popSystemNavigator()' on a null object reference, null, java.lang.NullPointerException: Attempt to invoke interface method 'boolean io.flutter.plugin.platform.PlatformPlugin$PlatformPluginDelegate.popSystemNavigator()' on a null object reference 2020-12-01T14:34:34.986682: stdout: [ ] E/flutter ( 9732): at io.flutter.plugin.platform.PlatformPlugin.popSystemNavigator(PlatformPlugin.java:313) stdout: [ ] E/flutter ( 9732): at io.flutter.plugin.platform.PlatformPlugin.access$600(PlatformPlugin.java:28) 2020-12-01T14:34:34.987013: stdout: [ ] E/flutter ( 9732): at io.flutter.plugin.platform.PlatformPlugin$1.popSystemNavigator(PlatformPlugin.java:101) 2020-12-01T14:34:34.987328: stdout: [ ] E/flutter ( 9732): at io.flutter.embedding.engine.systemchannels.PlatformChannel$1.onMethodCall(PlatformChannel.java:123) 2020-12-01T14:34:34.987547: stdout: [ ] E/flutter ( 9732): at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:233) 2020-12-01T14:34:34.987815: stdout: [ ] E/flutter ( 9732): at io.flutter.embedding.engine.dart.DartMessenger.handleMessageFromDart(DartMessenger.java:85) 2020-12-01T14:34:34.988037: stdout: [ ] E/flutter ( 9732): at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessage(FlutterJNI.java:738) 2020-12-01T14:34:34.988246: stdout: [ ] E/flutter ( 9732): at android.os.MessageQueue.nativePollOnce(Native Method) 2020-12-01T14:34:34.988470: stdout: [ ] E/flutter ( 9732): at android.os.MessageQueue.next(MessageQueue.java:323) 2020-12-01T14:34:34.988678: stdout: [ ] E/flutter ( 9732): at android.os.Looper.loop(Looper.java:136) 2020-12-01T14:34:34.988934: stdout: [ ] E/flutter ( 9732): at android.app.ActivityThread.main(ActivityThread.java:6123) 2020-12-01T14:34:34.989112: stdout: [ ] E/flutter ( 9732): at java.lang.reflect.Method.invoke(Native Method) 2020-12-01T14:34:34.989348: stdout: [ ] E/flutter ( 9732): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:867) 2020-12-01T14:34:34.990016: stdout: [ ] E/flutter ( 9732): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:757) stdout: [ ] E/flutter ( 9732): ), stack trace: #0 JSONMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:159:7) stdout: [ ] E/flutter ( 9732): #1 MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:159:18) 2020-12-01T14:34:34.990374: stdout: [ ] E/flutter ( 9732): <asynchronous suspension> 2020-12-01T14:34:34.990702: stdout: [ ] E/flutter ( 9732): #2 SystemNavigator.pop (package:flutter/src/services/system_navigator.dart:34:5) 2020-12-01T14:34:34.990946: stdout: [ ] E/flutter ( 9732): <asynchronous suspension> ``` This reverts commit 6a84b02.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change. If you're changing visual properties, consider including before/after screenshots (and runnable code snippets to reproduce them).
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR. There should be at least one issue listed here.
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behavior with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.