Make cirrus tests presubmit only and add new luci tests. #63995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now running most of the tests in luci postsubmit and presubmit. We are removing some of the presubmit tests from cirrus, making some of the remaining cirruss tests presubmit only and enabling more luci tests in the flutter dashboard. Bug: #63258
jmagman
reviewed
Aug 17, 2020
.cirrus.yml
Outdated
|
|
||
| windows_shard_template: &WINDOWS_SHARD_TEMPLATE | ||
| only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/**') || $CIRRUS_PR == ''" # https://github.com/flutter/flutter/issues/41941 | ||
| only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/**') && $CIRRUS_PR == ''" # https://github.com/flutter/flutter/issues/41941 |
Member
There was a problem hiding this comment.
Have Windows hostonly been migrated? I see https://ci.chromium.org/p/flutter/builders/prod/Windows%20hostonly_devicelab_tests but it's failing.
Contributor
Author
There was a problem hiding this comment.
Reverted to use ||
.cirrus.yml
Outdated
|
|
||
| macos_shard_template: &MACOS_SHARD_TEMPLATE | ||
| only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/**') || $CIRRUS_PR == ''" # https://github.com/flutter/flutter/issues/41941 | ||
| only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/**') && $CIRRUS_PR == ''" # https://github.com/flutter/flutter/issues/41941 |
Member
There was a problem hiding this comment.
I don't see hostonly_devicelab_tests for macOS on any builder, am I missing it?
Contributor
Author
There was a problem hiding this comment.
This was an error, back to ||
.cirrus.yml
Outdated
|
|
||
| windows_shard_template: &WINDOWS_SHARD_TEMPLATE | ||
| only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/**') || $CIRRUS_PR == ''" # https://github.com/flutter/flutter/issues/41941 | ||
| only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/**') && $CIRRUS_PR == ''" # https://github.com/flutter/flutter/issues/41941 |
Contributor
There was a problem hiding this comment.
we want this to ONLY run on post-submit?
Contributor
Author
There was a problem hiding this comment.
This was an error, back to ||
Contributor
Author
|
@jmagman @christopherfujino any other comments about this PR? |
jmagman
approved these changes
Aug 18, 2020
Member
jmagman
left a comment
There was a problem hiding this comment.
Not really familiar with how the builders.json work, but the .cirrus.yml LGTM!
This was referenced Aug 20, 2020
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are now running most of the tests in luci postsubmit and presubmit.
We are removing some of the presubmit tests from cirrus, making some of
the remaining cirruss tests presubmit only and enabling more luci tests
in the flutter dashboard.
Related Issues
Bug:
#63258
Tests
N/A
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.