Revert "Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. " #64091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
approved these changes
Aug 18, 2020
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
…the specified Rect is already visible. (flutter#56413)" (flutter#64091) This reverts commit 64d76f2.
LongCatIsLooong
added a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Aug 29, 2020
…the specified Rect is already visible. (flutter#56413)" reverted in flutter#64091
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…the specified Rect is already visible. (flutter#56413)" (flutter#64091) This reverts commit 64d76f2.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…the specified Rect is already visible. (flutter#56413)" reverted in flutter#64091 (flutter#64513)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #56413
This is causing unexpected failures internally that needs to be investigated.