fix wrap intrinsic height calculation #63420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Piinks
reviewed
Aug 10, 2020
Contributor
Piinks
left a comment
There was a problem hiding this comment.
This proposal looks good to me! Tests all check out too!
goderbauer
reviewed
Aug 11, 2020
| renderWrap.runSpacing = 0; | ||
| renderWrap.direction = Axis.horizontal; | ||
|
|
||
| const double oneLine = 14.0; |
Member
There was a problem hiding this comment.
Maybe comment where this is coming from or force the paragraph to actually use this size.
|
|
||
| final RenderWrap renderWrap = RenderWrap(); | ||
|
|
||
| children.forEach(renderWrap.add); |
Member
There was a problem hiding this comment.
Why not just renderWrap.add(RenderParagraph(...))?
Contributor
Author
|
ready for another look @goderbauer @Piinks |
goderbauer
approved these changes
Aug 12, 2020
| }); | ||
|
|
||
| test('Compute intrinsic height test for width-in-height-out children', () { | ||
| const double lineSize = 15.0; |
| }); | ||
|
|
||
| test('Compute intrinsic width test for height-in-width-out children', () { | ||
| const double lineSize = 15.0; |
mehmetf
added a commit
that referenced
this pull request
Aug 18, 2020
chunhtai
added a commit
to chunhtai/flutter
that referenced
this pull request
Aug 20, 2020
This reverts commit 473744d.
fluttergithubbot
pushed a commit
that referenced
this pull request
Aug 25, 2020
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Possible fix to wrap intrinsic problem
Related Issues
Fixes #61204
Fixes #63302
Tests
I added the following tests:
TBD
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.