Skip to content

Incorrect path.join usage might be causing Windows test failures #64056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 3 commits into from
Aug 19, 2020
Merged

Incorrect path.join usage might be causing Windows test failures #64056

fluttergithubbot merged 3 commits into from
Aug 19, 2020

Conversation

@xster
Copy link
Member

@xster xster commented Aug 18, 2020 •
edited
Loading

@xster xster requested a review from blasten August 18, 2020 17:06
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 18, 2020
@zanderso
Copy link
Member

zanderso commented Aug 18, 2020

I remember that there's some weirdness with asset paths on Windows /cc @jonahwilliams

@jonahwilliams
Copy link
Contributor

jonahwilliams commented Aug 18, 2020

I think the asset path weirdness is unrelated - it just seems like LUCI bots are stricter about / as a path separator

@xster
Copy link
Member Author

xster commented Aug 18, 2020

what's the "asset path weirdness" you guys referring to?

@xster
Copy link
Member Author

xster commented Aug 18, 2020

error • Too many positional arguments: 8 expected, but 10 found • dev/devicelab/bin/tasks/module_test.dart:257:58 • extra_positional_arguments 😂 that's probably why the original PR had it like that 😂

@fluttergithubbot fluttergithubbot merged commit b92f80e into flutter:master Aug 19, 2020
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
@xster @smadey
Incorrect path.join usage might be causing Windows test failures (flu…
0386e9f 
…tter#64056)
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@xster @mingwandroid
Incorrect path.join usage might be causing Windows test failures (flu…
dee3428 
…tter#64056)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xster @zanderso @jonahwilliams @blasten @googlebot @fluttergithubbot