Skip to content

Revert "[null-safety] enable null assertions for framework tests" #64118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Aug 19, 2020
Merged

Revert "[null-safety] enable null assertions for framework tests" #64118

jmagman merged 1 commit into from
Aug 19, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Aug 19, 2020

Reverts #64071

New test failures:

1:53 +891 ~12 -1: /b/s/w/ir/k/flutter/packages/flutter/test/rendering/simple_semantics_test.dart: only send semantics update if semantics have changed [E]                                            
  'package:flutter/src/semantics/semantics.dart': Failed assertion: line 0: 'value != null': is not true.
  dart:core                                             _AssertionError._throwNewNullAssertion
  package:flutter/src/semantics/semantics.dart          SemanticsConfiguration.explicitChildNodes=
  package:flutter/src/rendering/proxy_box.dart 4527:12  RenderSemanticsAnnotations.describeSemanticsConfiguration
  test/rendering/simple_semantics_test.dart 69:11       TestRender.describeSemanticsConfiguration
  package:flutter/src/rendering/object.dart 2524:7      RenderObject._semanticsConfiguration
  package:flutter/src/rendering/object.dart 1429:34     RenderObject.attach
  package:flutter/src/rendering/object.dart 3021:11     RenderObjectWithChildMixin.attach
  package:flutter/src/rendering/object.dart 3023:14     RenderObjectWithChildMixin.attach
  package:flutter/src/foundation/node.dart 132:13       AbstractNode.adoptChild
  package:flutter/src/rendering/object.dart 1290:11     RenderObject.adoptChild
  package:flutter/src/rendering/object.dart 3016:7      RenderObjectWithChildMixin.child=
  test/rendering/rendering_tester.dart 170:23           layout
  test/rendering/simple_semantics_test.dart 31:5        main.<fn>

01:55 +897 ~12 -2: /b/s/w/ir/k/flutter/packages/flutter/test/rendering/reattach_test.dart: objects can be detached and re-attached: layout [E]                                                         
  'package:flutter/src/semantics/semantics.dart': Failed assertion: line 0: 'value != null': is not true.
  dart:core                                               _AssertionError._throwNewNullAssertion
  package:flutter/src/semantics/semantics.dart            SemanticsConfiguration.explicitChildNodes=
  package:flutter/src/rendering/proxy_box.dart 4527:12    RenderSemanticsAnnotations.describeSemanticsConfiguration
  package:flutter/src/rendering/object.dart 2524:7        RenderObject._semanticsConfiguration
  package:flutter/src/rendering/object.dart 1429:34       RenderObject.attach
  package:flutter/src/rendering/object.dart 3021:11       RenderObjectWithChildMixin.attach
  package:flutter/src/rendering/object.dart 3023:14       RenderObjectWithChildMixin.attach
  package:flutter/src/rendering/object.dart 3023:14       RenderObjectWithChildMixin.attach
  package:flutter/src/rendering/object.dart 3023:14       RenderObjectWithChildMixin.attach
  package:flutter/src/rendering/custom_paint.dart 494:11  RenderCustomPaint.attach
  package:flutter/src/rendering/object.dart 3023:14       RenderObjectWithChildMixin.attach
  package:flutter/src/rendering/object.dart 3023:14       RenderObjectWithChildMixin.attach
  package:flutter/src/rendering/object.dart 3023:14       RenderObjectWithChildMixin.attach
  package:flutter/src/rendering/object.dart 3023:14       RenderObjectWithChildMixin.attach
  package:flutter/src/rendering/object.dart 3023:14       RenderObjectWithChildMixin.attach
  package:flutter/src/foundation/node.dart 132:13         AbstractNode.adoptChild
  package:flutter/src/rendering/object.dart 1290:11       RenderObject.adoptChild
  package:flutter/src/rendering/object.dart 3016:7        RenderObjectWithChildMixin.child=
  test/rendering/rendering_tester.dart 170:23             layout

https://api.cirrus-ci.com/v1/task/6444243294093312/logs/main.log
Also seen on LUCI.

@jmagman jmagman requested a review from jonahwilliams August 19, 2020 01:07
@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Aug 19, 2020
@jmagman
Copy link
Member Author

jmagman commented Aug 19, 2020

Merging to green the build.

@jmagman jmagman merged commit 1b47759 into master Aug 19, 2020
@jmagman jmagman deleted the revert-64071-fix_touch_slop_mouse branch August 19, 2020 01:08
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
@jmagman @smadey
Revert "[null-safety] enable null assertions for framework tests (flu…
6a82cd4 
…tter#64071)" (flutter#64118)

This reverts commit acdb909.
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jmagman @mingwandroid
Revert "[null-safety] enable null assertions for framework tests (flu…
043aef9 
…tter#64071)" (flutter#64118)

This reverts commit acdb909.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @googlebot