Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

Description

Also output covered | total lines, and a summary percentage at the end

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 18, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@christopherfujino
Copy link
Contributor

Are we even running this?

@jonahwilliams
Copy link
Contributor Author

I run this all the time

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams
Copy link
Contributor Author

Going to use this to kick the tree since it does not include any changes to running code

@jonahwilliams jonahwilliams merged commit f0dd4ad into flutter:master Aug 18, 2020
@jonahwilliams jonahwilliams deleted the add_more_lines_unit_coverage branch August 18, 2020 19:18
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
Also output covered | total lines, and a summary percentage at the end + Kick tree
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
Also output covered | total lines, and a summary percentage at the end + Kick tree
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants