Skip to content

Conversation

@aam
Copy link
Member

@aam aam commented Aug 17, 2020

Description

NoSuchMethodError constructor was deprecated, migrate flutter test to NoSuchMethodError.withInvocation.

Fixes dart-lang/sdk#33144

Underlying issue dart-lang/sdk#33124 was fixed in May, 2020, but use of deprecated method in flutter remained. This PR moves flutter away from deprecated method.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 17, 2020
@aam
Copy link
Member Author

aam commented Aug 17, 2020

@lrhn

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aam aam changed the title Move from deprecated NoSuchMethodError to NoSuchMethodError.withInvocation Move away from deprecated NoSuchMethodError to NoSuchMethodError.withInvocation Aug 17, 2020
@aam
Copy link
Member Author

aam commented Aug 17, 2020

thank you @goderbauer !

@fluttergithubbot fluttergithubbot merged commit 61362cf into flutter:master Aug 18, 2020
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NoSuchMethodError deprecation resolution doesn't work in Flutter

4 participants