Skip to content

KAFKA-17972: Set all tests inheriting from QuorumTestHarness to KRaft#17727

Closed
cmccabe wants to merge 1 commit into
apache:trunkfrom
cmccabe:KAFKA-17972
Closed

KAFKA-17972: Set all tests inheriting from QuorumTestHarness to KRaft#17727
cmccabe wants to merge 1 commit into
apache:trunkfrom
cmccabe:KAFKA-17972

Conversation

@cmccabe

@cmccabe cmccabe commented Nov 9, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added core Kafka Broker tests Test fixes (including flaky tests) small Small PRs labels Nov 9, 2024
@chia7712

chia7712 commented Nov 9, 2024

Copy link
Copy Markdown
Member

Out of curiosity, what is the next if we have a zk-only list?

  1. migrate the tests to Kraft if the tests are required by Kraft too
  2. Remove the tests if the bugs happen in Kraft only (similar to KAFKA-17925: Convert Kafka Client integration tests to use KRaft #17670 (comment))

Thanks

@cmccabe

cmccabe commented Nov 9, 2024

Copy link
Copy Markdown
Contributor Author

Out of curiosity, what is the next if we have a zk-only list?

There are some things that don't need to be tested any more, because they're gone. For example, there are a bunch of tests of "topics in deleting state" which can go, because deleting state is gone.

There are probably some tests that need to be migrated to KRaft, but haven't been yet. Depending on how many of them there are, we may need to put a @Disable on some of these and create a follow-up JIRA so that we can unblock the broader zk removal effort.

@cmccabe

cmccabe commented Nov 10, 2024

Copy link
Copy Markdown
Contributor Author

I split the fix of MetricsTest out to #17744

@cmccabe

cmccabe commented Nov 10, 2024

Copy link
Copy Markdown
Contributor Author

Remove MetadataRequestBetweenDifferentIbpTest.scala in #17745

@cmccabe

cmccabe commented Nov 10, 2024

Copy link
Copy Markdown
Contributor Author

Convert DescribeLogDirsRequestTest : #17746

cmccabe added a commit to cmccabe/kafka that referenced this pull request Nov 11, 2024
@cmccabe

cmccabe commented Nov 11, 2024

Copy link
Copy Markdown
Contributor Author

another fix here #17757

@cmccabe

cmccabe commented Nov 11, 2024

Copy link
Copy Markdown
Contributor Author

Fixing FetchRequestDownConversionConfigTest here : #17759

@cmccabe

cmccabe commented Nov 11, 2024

Copy link
Copy Markdown
Contributor Author

Convert ConsumerTopicCreationTest : https://github.com/apache/kafka/pull/17760/files

@cmccabe

cmccabe commented Nov 11, 2024

Copy link
Copy Markdown
Contributor Author

Convert AddPartitionsToTxnRequestServerTest #17762

@cmccabe

cmccabe commented Nov 12, 2024

Copy link
Copy Markdown
Contributor Author

Created #17765 for fixing the tests inheriting from RebootstrapTest

@cmccabe

cmccabe commented Nov 12, 2024

Copy link
Copy Markdown
Contributor Author

Convert RackAwareAutoTopicCreationTest to KRaft: #17766

@cmccabe

cmccabe commented Nov 12, 2024

Copy link
Copy Markdown
Contributor Author

Convert ProduceRequestTest : #17780

cmccabe added a commit to cmccabe/kafka that referenced this pull request Nov 12, 2024
@cmccabe

cmccabe commented Nov 13, 2024

Copy link
Copy Markdown
Contributor Author

Convert GssapiAuthenticationTest : https://github.com/apache/kafka/pull/17786/files

@cmccabe

cmccabe commented Nov 13, 2024

Copy link
Copy Markdown
Contributor Author

Convert SaslClientsWithInvalidCredentialsTest.scala to KRaft #17803

@cmccabe

cmccabe commented Nov 21, 2024

Copy link
Copy Markdown
Contributor Author

remove SaslPlainPlaintextConsumerTest.testZkAclsDisabled: #17902

cmccabe added a commit to cmccabe/kafka that referenced this pull request Nov 21, 2024
@cmccabe cmccabe force-pushed the KAFKA-17972 branch 2 times, most recently from c99b973 to 4f9c5e0 Compare November 21, 2024 22:04
@cmccabe

cmccabe commented Nov 22, 2024

Copy link
Copy Markdown
Contributor Author

For fixing DynamicBrokerReconfigurationTest : #17905

@cmccabe

cmccabe commented Nov 22, 2024

Copy link
Copy Markdown
Contributor Author

Remove some ZK tests here https://github.com/apache/kafka/pull/17913/files

cmccabe added a commit to cmccabe/kafka that referenced this pull request Nov 24, 2024
@github-actions github-actions Bot removed the small Small PRs label Nov 28, 2024
@cmccabe cmccabe changed the title KAFKA-17972: Default all JUnit tests to KRaft KAFKA-17972: Set all tests inheriting from QuorumTestHarness to KRaft Nov 28, 2024
@cmccabe

cmccabe commented Nov 30, 2024

Copy link
Copy Markdown
Contributor Author

Fix ConsumerBounceTest here: #17997

@github-actions github-actions Bot added the small Small PRs label Dec 14, 2024
@cmccabe

cmccabe commented Dec 19, 2024

Copy link
Copy Markdown
Contributor Author

It looks like isKRaftTest was removed in #18166 , so we no longer need this PR. I'll close it. Thanks, everyone!

@cmccabe cmccabe closed this Dec 19, 2024
@cmccabe cmccabe deleted the KAFKA-17972 branch December 19, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Kafka Broker small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants