Skip to content

MINOR: convert DescribeLogDirsRequestTest to KRaft#17746

Merged
mumrah merged 2 commits into
apache:trunkfrom
cmccabe:cmccabe_convert_DescribeLogDirsRequestTest
Nov 12, 2024
Merged

MINOR: convert DescribeLogDirsRequestTest to KRaft#17746
mumrah merged 2 commits into
apache:trunkfrom
cmccabe:cmccabe_convert_DescribeLogDirsRequestTest

Conversation

@cmccabe

@cmccabe cmccabe commented Nov 10, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added core Kafka Broker tests Test fixes (including flaky tests) small Small PRs labels Nov 10, 2024
@cmccabe cmccabe force-pushed the cmccabe_convert_DescribeLogDirsRequestTest branch from 063f00a to b04bbb4 Compare November 11, 2024 23:39
@mumrah

mumrah commented Nov 12, 2024

Copy link
Copy Markdown
Member

Looks like the test is failing:

FAILED ❌ DescribeLogDirsRequestTest > "testDescribeLogDirsRequest(String).quorum=kraft"

https://ge.apache.org/s/bmqnubbvhvxkq/tests/task/:core:test/details/kafka.server.DescribeLogDirsRequestTest/testDescribeLogDirsRequest(String)%5B1%5D?top-execution=1

@cmccabe

cmccabe commented Nov 12, 2024

Copy link
Copy Markdown
Contributor Author

Sorry, forgot to push something. It should be sending to a broker, not a controller, hence controllerSocketServer -> anySocketServer. Should be fixed now.

@mumrah mumrah merged commit 54fda50 into apache:trunk Nov 12, 2024

@mumrah mumrah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (retroactively 😅 )

chiacyu pushed a commit to chiacyu/kafka that referenced this pull request Nov 30, 2024
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Kafka Broker small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants