KAFKA-18226: Disable CustomQuotaCallbackTest and remove isKRaftTest#18166
Conversation
| TestUtils.createBrokerConfigs( | ||
| numServers, | ||
| zkConnectOrNull, | ||
| null, |
There was a problem hiding this comment.
Could we even remove the argument from createBrokerConfigs()?
There was a problem hiding this comment.
The createBrokerConfigs() will modify about 40 files, I will address it on another PR and open another Jira to trace it.
Update: I open Jira: KAFKA-18261
There was a problem hiding this comment.
Some tests are still using not null value on this method.
There was a problem hiding this comment.
That makes sense, then we can do this in another PR. Thanks
mimaison
left a comment
There was a problem hiding this comment.
Thanks for the PR. I left a few comments.
| controllerSocketServer | ||
| } | ||
| } | ||
| def adminSocketServer: SocketServer = anySocketServer |
| import scala.collection.mutable.ArrayBuffer | ||
| import scala.jdk.CollectionConverters._ | ||
|
|
||
| @Disabled |
| config.setProperty(SocketServerConfigs.LISTENER_SECURITY_PROTOCOL_MAP_CONFIG, (securityPairs ++ | ||
| toAdd.map(e => s"$e:${controllerListenerSecurityProtocol.toString}")).mkString(",")) | ||
| } | ||
| private def insertControllerListenersIfNeeded(props: Seq[Properties]): Unit = |
There was a problem hiding this comment.
Can we keep the curly brackets { and } around the method?
private def insertControllerListenersIfNeeded(props: Seq[Properties]): Unit = {
...
}
| } | ||
| } | ||
|
|
||
| object QuorumTestHarness { |
There was a problem hiding this comment.
Can we also remove the ZkClientEventThreadSuffix field from this object? Or is it still used?
There was a problem hiding this comment.
It still use on this, but I think we can remove it
| } else { | ||
| TestUtils.createTopic( | ||
| zkClient = zkClient, | ||
| ): scala.collection.immutable.Map[Int, Int] = |
There was a problem hiding this comment.
Let's keep the brackets around the method here too.
There was a problem hiding this comment.
Same for the other methods below
…18166) Reviewers: Mickael Maison <mickael.maison@gmail.com>
…pache#18166) Reviewers: Mickael Maison <mickael.maison@gmail.com>
Jira: https://issues.apache.org/jira/browse/KAFKA-18226
We change all tests to kraft mode, thus we didn't need to check which test is zk, we can remvoe check zk condition
Committer Checklist (excluded from commit message)