MINOR: Remove some obsolete JUnit tests#17745
Merged
chia7712 merged 5 commits intoNov 11, 2024
Merged
Conversation
The scenario that it tests cannot happen in KRaft, since MetadataVersion is dynamic in KRaft.
3 tasks
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Nov 30, 2024
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove MetadataRequestBetweenDifferentIbpTest.scala and
FetchRequestBetweenDifferentIbpTest.scala. The scenarios they test cannot happen in KRaft,
since MetadataVersion is now dynamic, not statically configured.
Remove FetchRequestWithLegacyMessageFormatTest.scala since legacy message formats are
no longer supported in KRaft.
Remove KafkaMetricReporterClusterIdTest.scala. It is a regression test for KAFKA-4756, but
since auto-generated broker IDs are no longer supported, this is not needed.
Remove FetchRequestTestDowngrade.scala. It tests some behaviors related to how the
ZK-based controller handles really old inter.broker.protocol versions (by removing topic IDs).
Since the ZK-based controller will be gone in 4.0, this is no longer needed.