Skip to content

MINOR: convert ConsumerBounceTest to KRaft#17997

Merged
chia7712 merged 3 commits into
apache:trunkfrom
cmccabe:cmccabe_consumer_bounce_test
Dec 6, 2024
Merged

MINOR: convert ConsumerBounceTest to KRaft#17997
chia7712 merged 3 commits into
apache:trunkfrom
cmccabe:cmccabe_consumer_bounce_test

Conversation

@cmccabe

@cmccabe cmccabe commented Nov 30, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added core Kafka Broker tests Test fixes (including flaky tests) labels Nov 30, 2024
@github-actions github-actions Bot added the small Small PRs label Nov 30, 2024

@chia7712 chia7712 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmccabe could you please replace all servers by brokerServers?

@frankvicky frankvicky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced servers with brokerServers locally and looped the test class. After this change, the tests are running very stably; otherwise, LGTM.

I=0; while ./gradlew core:test --tests ConsumerBounceTest --rerun --fail-fast; do  (( I=$I+1 )); echo “Completed run: $I”; sleep 1; done

Screenshot from 2024-12-01 14-08-04

@frankvicky

Copy link
Copy Markdown
Contributor

I will closed #17770

@cmccabe

cmccabe commented Dec 2, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for looking, @frankvicky

@chia7712

chia7712 commented Dec 5, 2024

Copy link
Copy Markdown
Member

@cmccabe I merge the trunk and use the brokerServers to fix error.

@chia7712

chia7712 commented Dec 6, 2024

Copy link
Copy Markdown
Member

Loop the test 300 times. Only testConsumptionWithBrokerFailures fails but it is already flaky (https://issues.apache.org/jira/browse/KAFKA-15146). I'm going to merge it

@chia7712 chia7712 merged commit 81ada39 into apache:trunk Dec 6, 2024
@cmccabe cmccabe deleted the cmccabe_consumer_bounce_test branch December 9, 2024 14:44
@jsancio jsancio self-assigned this Dec 17, 2024
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
Reviewers: TengYao Chi <kitingiao@gmail.com>, TaiJuWu <tjwu1217@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Kafka Broker small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants