Skip to content

MINOR: convert ConsumerTopicCreationTest to KRaft #17760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmccabe merged 1 commit into from
Nov 12, 2024
Merged

MINOR: convert ConsumerTopicCreationTest to KRaft #17760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/src/test/scala/integration/kafka/api/ConsumerTopicCreationTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ class ConsumerTopicCreationTest {
@MethodSource(Array("parameters"))
def testAutoTopicCreation(groupProtocol: String, brokerAutoTopicCreationEnable: JBoolean, consumerAllowAutoCreateTopics: JBoolean): Unit = {
val testCase = new ConsumerTopicCreationTest.TestCase(groupProtocol, brokerAutoTopicCreationEnable, consumerAllowAutoCreateTopics)
testCase.setUp(new EmptyTestInfo())
testCase.setUp(new EmptyTestInfo() {
override def getDisplayName = "quorum=kraft"
})
try testCase.test() finally testCase.tearDown()
}

Expand Down Expand Up @@ -88,7 +90,7 @@ object ConsumerTopicCreationTest {
}, "Timed out waiting to consume")

// MetadataRequest is guaranteed to create the topic znode if creation was required
val topicCreated = zkClient.getAllTopicsInCluster().contains(topic_2)
val topicCreated = getTopicIds().keySet.contains(topic_2)
if (brokerAutoTopicCreationEnable && consumerAllowAutoCreateTopics)
assertTrue(topicCreated)
else
Expand Down