MINOR: Convert FetchRequestDownConversionConfigTest.scala to KRaft#17759
Merged
cmccabe merged 2 commits intoNov 12, 2024
Merged
Conversation
dca5605 to
b5deeff
Compare
mimaison
approved these changes
Nov 12, 2024
| val topicMap = createTopics(numTopics = 5, numPartitions = 1) | ||
| val topicPartitions = topicMap.keySet.toSeq | ||
| val topicIds = servers.head.kafkaController.controllerContext.topicIds | ||
| val topicIds = getTopicIds() |
Member
There was a problem hiding this comment.
Nit: we can remove the toMap conversion below. Same in the other tests
b5deeff to
6c95e51
Compare
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Nov 30, 2024
…pache#17759) Reviewers: Mickael Maison <mickael.maison@gmail.com>
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
…pache#17759) Reviewers: Mickael Maison <mickael.maison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.