Skip to content

MINOR: convert AddPartitionsToTxnRequestServerTest to KRaft#17762

Merged
mumrah merged 1 commit into
apache:trunkfrom
cmccabe:convert_AddPartitionsToTxnRequestServerTest
Nov 12, 2024
Merged

MINOR: convert AddPartitionsToTxnRequestServerTest to KRaft#17762
mumrah merged 1 commit into
apache:trunkfrom
cmccabe:convert_AddPartitionsToTxnRequestServerTest

Conversation

@cmccabe

@cmccabe cmccabe commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added core Kafka Broker tests Test fixes (including flaky tests) small Small PRs labels Nov 11, 2024
@cmccabe cmccabe force-pushed the convert_AddPartitionsToTxnRequestServerTest branch from f072db8 to aab1dd3 Compare November 11, 2024 23:36
@mumrah

mumrah commented Nov 12, 2024

Copy link
Copy Markdown
Member

There's an initialization error in this test

https://github.com/apache/kafka/actions/runs/11787872102/job/32834070893?pr=17762

Gradle Test Run :core:test > Gradle Test Executor 118 > AddPartitionsToTxnRequestServerTest > testVerifyOnly(String) > initializationError STARTED
kafka.server.AddPartitionsToTxnRequestServerTest.initializationError failed, log available in /home/runner/work/kafka/kafka/core/build/reports/testOutput/kafka.server.AddPartitionsToTxnRequestServerTest.initializationError.test.stdout

Gradle Test Run :core:test > Gradle Test Executor 118 > AddPartitionsToTxnRequestServerTest > testVerifyOnly(String) > initializationError FAILED
    org.junit.platform.commons.PreconditionViolationException: Could not find factory method [kraft] in class [kafka.server.AddPartitionsToTxnRequestServerTest]
        at java.base@23.0.1/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
        at java.base@23.0.1/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:1024)
        at java.base@23.0.1/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:570)
        at java.base@23.0.1/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:560)
        at java.base@23.0.1/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
        at java.base@23.0.1/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
        at java.base@23.0.1/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:265)
        ```

edit: ah, looks like you need `@ValueSource` not `@MethodSource`

@cmccabe cmccabe force-pushed the convert_AddPartitionsToTxnRequestServerTest branch from 2f76b7b to 7888029 Compare November 12, 2024 20:39
@cmccabe cmccabe force-pushed the convert_AddPartitionsToTxnRequestServerTest branch from 7888029 to b0d464d Compare November 12, 2024 20:42

@mumrah mumrah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mumrah mumrah merged commit 1aa2447 into apache:trunk Nov 12, 2024
@cmccabe cmccabe deleted the convert_AddPartitionsToTxnRequestServerTest branch November 12, 2024 23:39
chiacyu pushed a commit to chiacyu/kafka that referenced this pull request Nov 30, 2024
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Kafka Broker small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants