📖Update documentation for carousel 0.2#23840
Merged
sparhami merged 8 commits intoampproject:masterfrom Aug 9, 2019
Merged
Conversation
added 5 commits
August 8, 2019 09:38
- Update the documentation to reflect the current state of carousel 0.2, with migration notes. - Fix a few thing in the documentation that were not correct for either 0.1 or 0.2. - Move the 0.1 documentation into the 0.1 folder, add a link from the new documentation to the version on Github. - Move the validator tests into the 0.2 folder since the validator rules match 0.2. - Remove the type slides/carousel destinction in the validator spec, the code no longer has a distinction for allowed layouts, autoplay, etc.
| <li>carousel: fixed, fixed-height, and nodisplay.</li> | ||
| <li>slides: fill, fixed, fixed-height, flex-item, nodisplay, and responsive.</li> | ||
| </ul> | ||
| fill, fixed, fixed-height, flex-item, intrinsic, nodisplay, and responsive. |
Contributor
There was a problem hiding this comment.
Are the examples below relevant to V2 or are they strictly V1?
Author
There was a problem hiding this comment.
They are relevant to both v1 and v2 (with a minor tweak to one of the examples for v2).
sparhami
pushed a commit
that referenced
this pull request
Aug 14, 2019
This reverts commit dc0001b.
sparhami
pushed a commit
that referenced
this pull request
Aug 15, 2019
dreamofabear
pushed a commit
that referenced
this pull request
Aug 15, 2019
Gregable
pushed a commit
that referenced
this pull request
Aug 16, 2019
* cl/262591581 Revision bump for #23840 * cl/262631527 Revision bump for #23765 * cl/263233041 data-ampdevmode. Avoid using non-data attributes on non-custom elements. * cl/263556980 Allow nonce on `<link rel=stylesheet>`. * cl/263618983 Revision bump for #23775 * cl/263623541 Revision bump for #23873 * cl/263628558 Revision bump for #23866 * cl/263637721 Revision bump for #23867 * cl/263656022 Revision bump for #23967 * fix reverse sync * fix reverse sync
sparhami
pushed a commit
that referenced
this pull request
Aug 16, 2019
sparhami
pushed a commit
that referenced
this pull request
Aug 16, 2019
westonruter
added a commit
to westonruter/amphtml
that referenced
this pull request
Aug 17, 2019
…cript-img-with-http-protocol * 'master' of github.com:ampproject/amphtml: (1326 commits) Fix and enable e2e tests for AMPHTML ads FIE rendering mode (ampproject#23995) 🏗 Update WorkerDOM to 0.17.0 (ampproject#24024) Make DocInfo.pageViewId64 async (ampproject#23998) 🐛 Updates amp-sidebar in amp-story (ampproject#23956) Revert "Revert "📖Update documentation for carousel 0.2 (ampproject#23840)" (ampproject#23967)" (ampproject#24016) 🔥 Revert "📈 Initial StorySpec Implementation (ampproject#23030)" (ampproject#24013) Extension skeleton code for payment widgets (ampproject#23045) 🏗🐛 Don't call `travisBuildNumber()` in the global scope (ampproject#24021) Remove suppressTypes from amp-mustache. (ampproject#23993) 🐛 Move `terser` from `dependencies` to `devDependencies` (ampproject#24018) Revert "Revert "Set the new loaders experiment to 1% of traffic. (ampproject#23780)" (ampproject#23963)" (ampproject#24014) SwG release 0.1.22.63 (ampproject#23997) Resolve navTiming variable earlier if possible (ampproject#23580) 🏗 Don't run all the runtime tests for validator-only changes (ampproject#24010) Collect document ready signal (ampproject#23981) Validator rollup (ampproject#24000) Remove flaky story branching test. (ampproject#23994) Include amp-base-carousel in amp-carousel's build. (ampproject#23984) Partial validator rollup (ampproject#23996) amp-bind: Rate-limit history operations (ampproject#23938) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4642
Closes #5977
Closes #9882
Closes #11734
Closes #11797
Closes #14505
Closes #15181
Closes #15822
Closes #17318
Closes #17741
Closes #20374
Closes #20685
/cc @nainar @CrystalOnScript