Support some new img attributes for those within noscript.#23765
Merged
sparhami merged 2 commits intoampproject:masterfrom Aug 9, 2019
Merged
Support some new img attributes for those within noscript.#23765sparhami merged 2 commits intoampproject:masterfrom
sparhami merged 2 commits intoampproject:masterfrom
Conversation
These attributes help to get some of the nice features of AMP (layout stability, async loading) when scripts are not enabled. We might consider allowing `<img intrinsicsize="blah x blah" loading="lazy">` as an alternative to `<amp-img>` in the future if polyfilling the attributes is feasible.
Gregable
reviewed
Aug 8, 2019
validator/validator-main.protoascii
Outdated
| } | ||
| attrs: { name: "importance" } # Not yet part of the html spec | ||
| attrs: { name: "intrinsicsize" } # Not yet part of the html spec | ||
| attrs: { name: "loading" } # Not yet part of the html spec |
Member
There was a problem hiding this comment.
please leave 2 spaces between code and comment on same line
Gregable
approved these changes
Aug 8, 2019
Member
|
@kristoferbaxter this may be relevant to your interests |
Contributor
|
Adding notes here for each of these attributes.
|
Gregable
pushed a commit
that referenced
this pull request
Aug 16, 2019
* cl/262591581 Revision bump for #23840 * cl/262631527 Revision bump for #23765 * cl/263233041 data-ampdevmode. Avoid using non-data attributes on non-custom elements. * cl/263556980 Allow nonce on `<link rel=stylesheet>`. * cl/263618983 Revision bump for #23775 * cl/263623541 Revision bump for #23873 * cl/263628558 Revision bump for #23866 * cl/263637721 Revision bump for #23867 * cl/263656022 Revision bump for #23967 * fix reverse sync * fix reverse sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These attributes help to get some of the nice features of AMP (layout
stability, async loading) when scripts are not enabled for browsers that support them.
We might consider allowing
<img intrinsicsize="blah x blah" loading="lazy">as an alternative to
<amp-img>in the future if polyfilling the attributes isfeasible.
Closes #22802