Skip to content

amp-script src/script should use mandatory_oneof#23867

Merged
dreamofabear merged 4 commits intoampproject:masterfrom
dreamofabear:script-oneof
Aug 13, 2019
Merged

amp-script src/script should use mandatory_oneof#23867
dreamofabear merged 4 commits intoampproject:masterfrom
dreamofabear:script-oneof

Conversation

@dreamofabear
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@twifkak twifkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this affecting any current pages? AFAICT <script> is still invalid as of #23147, so <amp-script script> isn't useful for valid AMP pages.

@dreamofabear
Copy link
Copy Markdown
Author

Yea, that's why I think it should be safe.

@dreamofabear dreamofabear merged commit 62a9eab into ampproject:master Aug 13, 2019
@dreamofabear dreamofabear deleted the script-oneof branch August 13, 2019 21:49
Gregable pushed a commit that referenced this pull request Aug 16, 2019
* cl/262591581 Revision bump for #23840

* cl/262631527 Revision bump for #23765

* cl/263233041 data-ampdevmode. Avoid using non-data attributes on non-custom elements.

* cl/263556980 Allow nonce on `<link rel=stylesheet>`.

* cl/263618983 Revision bump for #23775

* cl/263623541 Revision bump for #23873

* cl/263628558 Revision bump for #23866

* cl/263637721 Revision bump for #23867

* cl/263656022 Revision bump for #23967

* fix reverse sync

* fix reverse sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants