Update amp-date-display validation to allow template attribute#23866
Merged
cathyxz merged 2 commits intoampproject:masterfrom Aug 12, 2019
Merged
Update amp-date-display validation to allow template attribute#23866cathyxz merged 2 commits intoampproject:masterfrom
cathyxz merged 2 commits intoampproject:masterfrom
Conversation
Member
|
fyi @twifkak as this might interact with the bug you are working on. |
Gregable
approved these changes
Aug 9, 2019
dreamofabear
approved these changes
Aug 9, 2019
This was referenced Aug 12, 2019
Gregable
pushed a commit
that referenced
this pull request
Aug 16, 2019
* cl/262591581 Revision bump for #23840 * cl/262631527 Revision bump for #23765 * cl/263233041 data-ampdevmode. Avoid using non-data attributes on non-custom elements. * cl/263556980 Allow nonce on `<link rel=stylesheet>`. * cl/263618983 Revision bump for #23775 * cl/263623541 Revision bump for #23873 * cl/263628558 Revision bump for #23866 * cl/263637721 Revision bump for #23867 * cl/263656022 Revision bump for #23967 * fix reverse sync * fix reverse sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23731.
Context:
amp-date-displaymakes use of<template>s. It should therefore allow thetemplateattribute to reference templates without causing template nesting when used inside of<amp-list>.