Extension skeleton code for payment widgets#23045
Merged
dreamofabear merged 4 commits intoampproject:masterfrom Aug 16, 2019
Merged
Extension skeleton code for payment widgets#23045dreamofabear merged 4 commits intoampproject:masterfrom
dreamofabear merged 4 commits intoampproject:masterfrom
Conversation
|
/to @choumx |
Gregable
previously requested changes
Jun 26, 2019
Member
Gregable
left a comment
There was a problem hiding this comment.
I would recommend holding off on the validator.*protoascii files until you have fleshed out the details of the implementation a bit more, since that will make the validator rules changes release rather quickly.
Member
|
Is this PR still active? |
dreamofabear
approved these changes
Aug 15, 2019
dreamofabear
left a comment
There was a problem hiding this comment.
Please comment out the validator rules in the .protoascii file.
Contributor
Author
|
commented out protoascii files |
added 2 commits
August 15, 2019 16:14
Validator rules were commented out.
westonruter
added a commit
to westonruter/amphtml
that referenced
this pull request
Aug 17, 2019
…cript-img-with-http-protocol * 'master' of github.com:ampproject/amphtml: (1326 commits) Fix and enable e2e tests for AMPHTML ads FIE rendering mode (ampproject#23995) 🏗 Update WorkerDOM to 0.17.0 (ampproject#24024) Make DocInfo.pageViewId64 async (ampproject#23998) 🐛 Updates amp-sidebar in amp-story (ampproject#23956) Revert "Revert "📖Update documentation for carousel 0.2 (ampproject#23840)" (ampproject#23967)" (ampproject#24016) 🔥 Revert "📈 Initial StorySpec Implementation (ampproject#23030)" (ampproject#24013) Extension skeleton code for payment widgets (ampproject#23045) 🏗🐛 Don't call `travisBuildNumber()` in the global scope (ampproject#24021) Remove suppressTypes from amp-mustache. (ampproject#23993) 🐛 Move `terser` from `dependencies` to `devDependencies` (ampproject#24018) Revert "Revert "Set the new loaders experiment to 1% of traffic. (ampproject#23780)" (ampproject#23963)" (ampproject#24014) SwG release 0.1.22.63 (ampproject#23997) Resolve navTiming variable earlier if possible (ampproject#23580) 🏗 Don't run all the runtime tests for validator-only changes (ampproject#24010) Collect document ready signal (ampproject#23981) Validator rollup (ampproject#24000) Remove flaky story branching test. (ampproject#23994) Include amp-base-carousel in amp-carousel's build. (ampproject#23984) Partial validator rollup (ampproject#23996) amp-bind: Rate-limit history operations (ampproject#23938) ...
twifkak
added a commit
to twifkak/amphtml
that referenced
this pull request
Aug 21, 2019
Merged
twifkak
added a commit
that referenced
this pull request
Aug 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates the skeleton code for the payment widgets with updated names
After code implementation and service files are added, legacy payment extensions will be removed