Skip to content

Remove flaky amp-story branching test#23994

Merged
gmajoulet merged 1 commit intoampproject:masterfrom
dreamofabear:skip-story-branch-test
Aug 16, 2019
Merged

Remove flaky amp-story branching test#23994
gmajoulet merged 1 commit intoampproject:masterfrom
dreamofabear:skip-story-branch-test

Conversation

@dreamofabear
Copy link
Copy Markdown

@dreamofabear dreamofabear commented Aug 15, 2019 •
edited
Loading 

DESCRIBE => AmpDocService
  DESCRIBE => amp-story
    DESCRIBE =>  
      DESCRIBE => amp-story branching
        IT => "after each" hook for "should navigate to the correct previous page after navigating away"
          ✗ Error: Blocked a frame with origin "http://localhost:9876" from accessing a cross-origin frame.
              at experimentToggles (home/travis/build/ampproject/amphtml/src/experiments.js:127:10)
              at isExperimentOn (home/travis/build/ampproject/amphtml/src/experiments.js:73:19)
              at toggleExperiment (home/travis/build/ampproject/amphtml/src/experiments.js:95:23)
              at Context.<anonymous> (home/travis/build/ampproject/amphtml/extensions/amp-story/1.0/test/test-amp-story.js:1583:9)
HeadlessChrome 76.0.3809 (Linux 0.0.0) AmpDocService amp-story   amp-story branching "after each" hook for "should navigate to the correct previous page after navigating away" FAILED
	Error: Blocked a frame with origin "http://localhost:9876" from accessing a cross-origin frame.
	    at experimentToggles (home/travis/build/ampproject/amphtml/src/experiments.js:127:10)
	    at isExperimentOn (home/travis/build/ampproject/amphtml/src/experiments.js:73:19)
	    at toggleExperiment (home/travis/build/ampproject/amphtml/src/experiments.js:95:23)
	    at Context.<anonymous> (home/travis/build/ampproject/amphtml/extensions/amp-story/1.0/test/test-amp-story.js:1583:9)
●
    IT => "after each" hook for "should navigate to the correct previous page after navigating away"
      ✗ Error: Blocked a frame with origin "http://localhost:9876" from accessing a cross-origin frame.
          at AmpFixture.teardown (home/travis/build/ampproject/amphtml/testing/describes.js:864:13)
          at http://localhost:9876/home/travis/build/ampproject/amphtml/testing/describes.js:335:52
HeadlessChrome 76.0.3809 (Linux 0.0.0) AmpDocService amp-story "after each" hook for "should navigate to the correct previous page after navigating away" FAILED
	Error: Blocked a frame with origin "http://localhost:9876" from accessing a cross-origin frame.
	    at AmpFixture.teardown (home/travis/build/ampproject/amphtml/testing/describes.js:864:13)
	    at http://localhost:9876/home/travis/build/ampproject/amphtml/testing/describes.js:335:52

/to @gmajoulet

@dreamofabear dreamofabear requested a review from gmajoulet August 15, 2019 22:38
gmajoulet
gmajoulet approved these changes Aug 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gmajoulet gmajoulet merged commit 7b2162a into ampproject:master Aug 16, 2019
@dreamofabear dreamofabear deleted the skip-story-branch-test branch August 16, 2019 16:41
westonruter added a commit to westonruter/amphtml that referenced this pull request Aug 17, 2019
@westonruter
Merge branch 'master' of github.com:ampproject/amphtml into allow/nos…
54ebf90 
…cript-img-with-http-protocol

* 'master' of github.com:ampproject/amphtml: (1326 commits)
  Fix and enable e2e tests for AMPHTML ads FIE rendering mode (ampproject#23995)
  🏗 Update WorkerDOM to 0.17.0 (ampproject#24024)
  Make DocInfo.pageViewId64 async (ampproject#23998)
  🐛 Updates amp-sidebar in amp-story  (ampproject#23956)
  Revert "Revert "📖Update documentation for carousel 0.2 (ampproject#23840)" (ampproject#23967)" (ampproject#24016)
  🔥 Revert "📈 Initial StorySpec Implementation (ampproject#23030)" (ampproject#24013)
  Extension skeleton code for payment widgets (ampproject#23045)
  🏗🐛 Don't call `travisBuildNumber()` in the global scope (ampproject#24021)
  Remove suppressTypes from amp-mustache. (ampproject#23993)
  🐛 Move `terser` from `dependencies` to `devDependencies` (ampproject#24018)
  Revert "Revert "Set the new loaders experiment to 1% of traffic. (ampproject#23780)" (ampproject#23963)" (ampproject#24014)
  SwG release 0.1.22.63 (ampproject#23997)
  Resolve navTiming variable earlier if possible (ampproject#23580)
  🏗 Don't run all the runtime tests for validator-only changes (ampproject#24010)
  Collect document ready signal (ampproject#23981)
  Validator rollup (ampproject#24000)
  Remove flaky story branching test. (ampproject#23994)
  Include amp-base-carousel in amp-carousel's build. (ampproject#23984)
  Partial validator rollup (ampproject#23996)
  amp-bind: Rate-limit history operations (ampproject#23938)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dreamofabear @gmajoulet @googlebot