Skip to content

Revert "Set the new loaders experiment to 1% of traffic."#23963

Merged
sparhami merged 1 commit intomasterfrom
revert-23780-loaders_rollout
Aug 14, 2019
Merged

Revert "Set the new loaders experiment to 1% of traffic."#23963
sparhami merged 1 commit intomasterfrom
revert-23780-loaders_rollout

Conversation

@sparhami
Copy link
Copy Markdown

@sparhami sparhami commented Aug 14, 2019

Reverts #23780

This has a race condition where the default placeholder may not be removed with amp-img and potentially other components.

Fixes #23964

@sparhami sparhami merged commit 48f9a82 into master Aug 14, 2019
dreamofabear pushed a commit that referenced this pull request Aug 15, 2019
sparhami pushed a commit that referenced this pull request Aug 16, 2019
sparhami pushed a commit that referenced this pull request Aug 16, 2019
westonruter added a commit to westonruter/amphtml that referenced this pull request Aug 17, 2019
…cript-img-with-http-protocol

* 'master' of github.com:ampproject/amphtml: (1326 commits)
  Fix and enable e2e tests for AMPHTML ads FIE rendering mode (ampproject#23995)
  🏗 Update WorkerDOM to 0.17.0 (ampproject#24024)
  Make DocInfo.pageViewId64 async (ampproject#23998)
  🐛 Updates amp-sidebar in amp-story  (ampproject#23956)
  Revert "Revert "📖Update documentation for carousel 0.2 (ampproject#23840)" (ampproject#23967)" (ampproject#24016)
  🔥 Revert "📈 Initial StorySpec Implementation (ampproject#23030)" (ampproject#24013)
  Extension skeleton code for payment widgets (ampproject#23045)
  🏗🐛 Don't call `travisBuildNumber()` in the global scope (ampproject#24021)
  Remove suppressTypes from amp-mustache. (ampproject#23993)
  🐛 Move `terser` from `dependencies` to `devDependencies` (ampproject#24018)
  Revert "Revert "Set the new loaders experiment to 1% of traffic. (ampproject#23780)" (ampproject#23963)" (ampproject#24014)
  SwG release 0.1.22.63 (ampproject#23997)
  Resolve navTiming variable earlier if possible (ampproject#23580)
  🏗 Don't run all the runtime tests for validator-only changes (ampproject#24010)
  Collect document ready signal (ampproject#23981)
  Validator rollup (ampproject#24000)
  Remove flaky story branching test. (ampproject#23994)
  Include amp-base-carousel in amp-carousel's build. (ampproject#23984)
  Partial validator rollup (ampproject#23996)
  amp-bind: Rate-limit history operations (ampproject#23938)
  ...
@rsimha rsimha deleted the revert-23780-loaders_rollout branch September 17, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Race condition in new loader placeholders

3 participants