fix: trending tokens show incorrect MC value#7829
Merged
Conversation
c6b7631 to
76c8a83
Compare
Member
Author
|
@cursor update te assets changelog to reflect my change |
|
I've successfully updated the assets-controllers changelog to reflect your trending tokens fix. Here's what I added:
The changelog entry is now committed and pushed to the |
Co-authored-by: Juanmi <juanmigdr@users.noreply.github.com>
Prithpal-Sooriya
approved these changes
Feb 4, 2026
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Feb 11, 2026
…3.18.0 (#39887) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. [skip-e2e] --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR bump `@metamask/assets-controllers` from `^99.0.0` to `^99.3.1`. The current resolved version in the `yarn.lock` is `99.1.0`, which includes a change that introduces a bug with Tempo native balances. A fix has been released in `99.3.1`, so we need to bump to that version to get the fix. The cherry-pick into `13.18.0` is necessary as it includes the affected version of `@metamask/assets-controllers`, and we don't want it to reach production. ```markdown ## [99.3.1] ### Fixed - Remove `Tempo Testnet` multicall address ([#7858](MetaMask/core#7858)). ## [99.3.0] ### Added - Add optional `rwaData` support when adding tokens in `TokensController` ([#7804](MetaMask/core#7804)). ### Changed - Lock `@metamask/core-backend` to `5.0.0` ([#7852](MetaMask/core#7852)) - Bump `@metamask/profile-sync-controller` from `^27.0.0` to `^27.1.0` ([#7849](MetaMask/core#7849)) - Fix trending tokens showing incorrect market cap values by adding `usePriceApiData` parameter (defaults to `true`) to use price API data for accurate market data ([#7829](MetaMask/core#7829)) - Bump `@metamask/transaction-controller` from `^62.13.0` to `^62.15.0` ([#7832](MetaMask/core#7832), [#7854](MetaMask/core#7854)) ## [99.2.0] ### Added - Add `HYPEREVM` support ([#7790](MetaMask/core#7790)) - Add `HYPEREVM` in `SupportedTokenDetectionNetworks` - Add `HYPEREVM` in `SUPPORTED_NETWORKS_ACCOUNTS_API_V4` ### Changed - Simplify TokenListController initialization ([#7740](MetaMask/core#7740)) - Bump `@metamask/storage-service` from `^0.0.1` to `^1.0.0` ([#7797](MetaMask/core#7797)) - Bump `@metamask/transaction-controller` from `^62.11.0` to `^62.13.0` ([#7775](MetaMask/core#7775), [#7802](MetaMask/core#7802)) - Bump `@metamask/preferences-controller` from `^22.0.0` to `^22.1.0` ([#7802](MetaMask/core#7802)) ### Removed - Removed token-search-discovery-controller package ([#7789](MetaMask/core#7789)) ``` [](https://codespaces.new/MetaMask/metamask-extension/pull/39887?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Dependency upgrade in a core controllers package can change token/balance behavior and introduces transitive version shifts; risk is mitigated by being a targeted bump intended to pick up a bugfix release. > > **Overview** > Bumps `@metamask/assets-controllers` from `^99.0.0` to `^99.3.1` and refreshes `yarn.lock` to resolve to `99.3.1`. > > Removes the Yarn patch previously applied to `@metamask/assets-controllers@93.1.0` (and its patched exchange-rate precision changes), relying on upstream package fixes instead; lockfile also reflects updated transitive constraints (e.g., pinning `@metamask/core-backend` to `5.0.0` and newer controller deps). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 7457931. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Prithpal Sooriya <prithpal.sooriya@consensys.net>
runway-github bot
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Feb 11, 2026
… cp-13.18.0 (#39887) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. [skip-e2e] --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR bump `@metamask/assets-controllers` from `^99.0.0` to `^99.3.1`. The current resolved version in the `yarn.lock` is `99.1.0`, which includes a change that introduces a bug with Tempo native balances. A fix has been released in `99.3.1`, so we need to bump to that version to get the fix. The cherry-pick into `13.18.0` is necessary as it includes the affected version of `@metamask/assets-controllers`, and we don't want it to reach production. ```markdown ## [99.3.1] ### Fixed - Remove `Tempo Testnet` multicall address ([#7858](MetaMask/core#7858)). ## [99.3.0] ### Added - Add optional `rwaData` support when adding tokens in `TokensController` ([#7804](MetaMask/core#7804)). ### Changed - Lock `@metamask/core-backend` to `5.0.0` ([#7852](MetaMask/core#7852)) - Bump `@metamask/profile-sync-controller` from `^27.0.0` to `^27.1.0` ([#7849](MetaMask/core#7849)) - Fix trending tokens showing incorrect market cap values by adding `usePriceApiData` parameter (defaults to `true`) to use price API data for accurate market data ([#7829](MetaMask/core#7829)) - Bump `@metamask/transaction-controller` from `^62.13.0` to `^62.15.0` ([#7832](MetaMask/core#7832), [#7854](MetaMask/core#7854)) ## [99.2.0] ### Added - Add `HYPEREVM` support ([#7790](MetaMask/core#7790)) - Add `HYPEREVM` in `SupportedTokenDetectionNetworks` - Add `HYPEREVM` in `SUPPORTED_NETWORKS_ACCOUNTS_API_V4` ### Changed - Simplify TokenListController initialization ([#7740](MetaMask/core#7740)) - Bump `@metamask/storage-service` from `^0.0.1` to `^1.0.0` ([#7797](MetaMask/core#7797)) - Bump `@metamask/transaction-controller` from `^62.11.0` to `^62.13.0` ([#7775](MetaMask/core#7775), [#7802](MetaMask/core#7802)) - Bump `@metamask/preferences-controller` from `^22.0.0` to `^22.1.0` ([#7802](MetaMask/core#7802)) ### Removed - Removed token-search-discovery-controller package ([#7789](MetaMask/core#7789)) ``` [](https://codespaces.new/MetaMask/metamask-extension/pull/39887?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Dependency upgrade in a core controllers package can change token/balance behavior and introduces transitive version shifts; risk is mitigated by being a targeted bump intended to pick up a bugfix release. > > **Overview** > Bumps `@metamask/assets-controllers` from `^99.0.0` to `^99.3.1` and refreshes `yarn.lock` to resolve to `99.3.1`. > > Removes the Yarn patch previously applied to `@metamask/assets-controllers@93.1.0` (and its patched exchange-rate precision changes), relying on upstream package fixes instead; lockfile also reflects updated transitive constraints (e.g., pinning `@metamask/core-backend` to `5.0.0` and newer controller deps). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 7457931. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Prithpal Sooriya <prithpal.sooriya@consensys.net>
Prithpal-Sooriya
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Feb 11, 2026
…3.18.0 (#39887) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. [skip-e2e] --> <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR bump `@metamask/assets-controllers` from `^99.0.0` to `^99.3.1`. The current resolved version in the `yarn.lock` is `99.1.0`, which includes a change that introduces a bug with Tempo native balances. A fix has been released in `99.3.1`, so we need to bump to that version to get the fix. The cherry-pick into `13.18.0` is necessary as it includes the affected version of `@metamask/assets-controllers`, and we don't want it to reach production. ```markdown - Remove `Tempo Testnet` multicall address ([#7858](MetaMask/core#7858)). - Add optional `rwaData` support when adding tokens in `TokensController` ([#7804](MetaMask/core#7804)). - Lock `@metamask/core-backend` to `5.0.0` ([#7852](MetaMask/core#7852)) - Bump `@metamask/profile-sync-controller` from `^27.0.0` to `^27.1.0` ([#7849](MetaMask/core#7849)) - Fix trending tokens showing incorrect market cap values by adding `usePriceApiData` parameter (defaults to `true`) to use price API data for accurate market data ([#7829](MetaMask/core#7829)) - Bump `@metamask/transaction-controller` from `^62.13.0` to `^62.15.0` ([#7832](MetaMask/core#7832), [#7854](MetaMask/core#7854)) - Add `HYPEREVM` support ([#7790](MetaMask/core#7790)) - Add `HYPEREVM` in `SupportedTokenDetectionNetworks` - Add `HYPEREVM` in `SUPPORTED_NETWORKS_ACCOUNTS_API_V4` - Simplify TokenListController initialization ([#7740](MetaMask/core#7740)) - Bump `@metamask/storage-service` from `^0.0.1` to `^1.0.0` ([#7797](MetaMask/core#7797)) - Bump `@metamask/transaction-controller` from `^62.11.0` to `^62.13.0` ([#7775](MetaMask/core#7775), [#7802](MetaMask/core#7802)) - Bump `@metamask/preferences-controller` from `^22.0.0` to `^22.1.0` ([#7802](MetaMask/core#7802)) - Removed token-search-discovery-controller package ([#7789](MetaMask/core#7789)) ``` [](https://codespaces.new/MetaMask/metamask-extension/pull/39887?quickstart=1) <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null Fixes: 1. Go to this page... 2. 3. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Dependency upgrade in a core controllers package can change token/balance behavior and introduces transitive version shifts; risk is mitigated by being a targeted bump intended to pick up a bugfix release. > > **Overview** > Bumps `@metamask/assets-controllers` from `^99.0.0` to `^99.3.1` and refreshes `yarn.lock` to resolve to `99.3.1`. > > Removes the Yarn patch previously applied to `@metamask/assets-controllers@93.1.0` (and its patched exchange-rate precision changes), relying on upstream package fixes instead; lockfile also reflects updated transitive constraints (e.g., pinning `@metamask/core-backend` to `5.0.0` and newer controller deps). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 7457931. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Prithpal Sooriya <prithpal.sooriya@consensys.net>
github-merge-queue bot
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Feb 18, 2026
#25796) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR bump `@metamask/assets-controllers` from `^99.0.0` to `^99.3.1`. The current resolved version in the `yarn.lock` is `99.1.0`, which includes a change that introduces a bug with Tempo native balances. A fix has been released in `99.3.1`, so we need to bump to that version to get the fix. ```markdown ## [99.3.1] ### Fixed - Remove `Tempo Testnet` multicall address ([#7858](MetaMask/core#7858)). ## [99.3.0] ### Added - Add optional `rwaData` support when adding tokens in `TokensController` ([#7804](MetaMask/core#7804)). ### Changed - Lock `@metamask/core-backend` to `5.0.0` ([#7852](MetaMask/core#7852)) - Bump `@metamask/profile-sync-controller` from `^27.0.0` to `^27.1.0` ([#7849](MetaMask/core#7849)) - Fix trending tokens showing incorrect market cap values by adding `usePriceApiData` parameter (defaults to `true`) to use price API data for accurate market data ([#7829](MetaMask/core#7829)) - Bump `@metamask/transaction-controller` from `^62.13.0` to `^62.15.0` ([#7832](MetaMask/core#7832), [#7854](MetaMask/core#7854)) ## [99.2.0] ### Added - Add `HYPEREVM` support ([#7790](MetaMask/core#7790)) - Add `HYPEREVM` in `SupportedTokenDetectionNetworks` - Add `HYPEREVM` in `SUPPORTED_NETWORKS_ACCOUNTS_API_V4` ### Changed - Simplify TokenListController initialization ([#7740](MetaMask/core#7740)) - Bump `@metamask/storage-service` from `^0.0.1` to `^1.0.0` ([#7797](MetaMask/core#7797)) - Bump `@metamask/transaction-controller` from `^62.11.0` to `^62.13.0` ([#7775](MetaMask/core#7775), [#7802](MetaMask/core#7802)) - Bump `@metamask/preferences-controller` from `^22.0.0` to `^22.1.0` ([#7802](MetaMask/core#7802)) ### Removed - Removed token-search-discovery-controller package ([#7789](MetaMask/core#7789)) ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Dependency upgrade in core asset/balance controller codepaths could change token balance fetching behavior at runtime; test changes are low risk but lockfile churn may mask subtle transitive updates. > > **Overview** > Updates `@metamask/assets-controllers` to `^99.3.1` and drops the local Yarn patch previously applied to `99.2.0`, letting the app consume the upstream fixes (including the Tempo native balance regression noted in the PR context). > > Cleans up `TokenBalancesController`/`TokenDetectionController` messenger unit tests by removing locally-declared `RootMessenger` generic types and reusing the shared `RootMessenger` type from `app/core/Engine/types`. Lockfile/resolution entries are updated accordingly to reflect the new dependency graph. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0e1ee10. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Sébastien Van Eyck <sebastien.vaneyck@consensys.net>
grvgoel81
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Feb 23, 2026
#25796) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR bump `@metamask/assets-controllers` from `^99.0.0` to `^99.3.1`. The current resolved version in the `yarn.lock` is `99.1.0`, which includes a change that introduces a bug with Tempo native balances. A fix has been released in `99.3.1`, so we need to bump to that version to get the fix. ```markdown ## [99.3.1] ### Fixed - Remove `Tempo Testnet` multicall address ([#7858](MetaMask/core#7858)). ## [99.3.0] ### Added - Add optional `rwaData` support when adding tokens in `TokensController` ([#7804](MetaMask/core#7804)). ### Changed - Lock `@metamask/core-backend` to `5.0.0` ([#7852](MetaMask/core#7852)) - Bump `@metamask/profile-sync-controller` from `^27.0.0` to `^27.1.0` ([#7849](MetaMask/core#7849)) - Fix trending tokens showing incorrect market cap values by adding `usePriceApiData` parameter (defaults to `true`) to use price API data for accurate market data ([#7829](MetaMask/core#7829)) - Bump `@metamask/transaction-controller` from `^62.13.0` to `^62.15.0` ([#7832](MetaMask/core#7832), [#7854](MetaMask/core#7854)) ## [99.2.0] ### Added - Add `HYPEREVM` support ([#7790](MetaMask/core#7790)) - Add `HYPEREVM` in `SupportedTokenDetectionNetworks` - Add `HYPEREVM` in `SUPPORTED_NETWORKS_ACCOUNTS_API_V4` ### Changed - Simplify TokenListController initialization ([#7740](MetaMask/core#7740)) - Bump `@metamask/storage-service` from `^0.0.1` to `^1.0.0` ([#7797](MetaMask/core#7797)) - Bump `@metamask/transaction-controller` from `^62.11.0` to `^62.13.0` ([#7775](MetaMask/core#7775), [#7802](MetaMask/core#7802)) - Bump `@metamask/preferences-controller` from `^22.0.0` to `^22.1.0` ([#7802](MetaMask/core#7802)) ### Removed - Removed token-search-discovery-controller package ([#7789](MetaMask/core#7789)) ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Dependency upgrade in core asset/balance controller codepaths could change token balance fetching behavior at runtime; test changes are low risk but lockfile churn may mask subtle transitive updates. > > **Overview** > Updates `@metamask/assets-controllers` to `^99.3.1` and drops the local Yarn patch previously applied to `99.2.0`, letting the app consume the upstream fixes (including the Tempo native balance regression noted in the PR context). > > Cleans up `TokenBalancesController`/`TokenDetectionController` messenger unit tests by removing locally-declared `RootMessenger` generic types and reusing the shared `RootMessenger` type from `app/core/Engine/types`. Lockfile/resolution entries are updated accordingly to reflect the new dependency graph. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0e1ee10. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Sébastien Van Eyck <sebastien.vaneyck@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Explanation
Fix bug on the trending API, seems like it returns USDC on Base with a 4B marketcap instead of 70B. Here is a video. Here is the search request returning 70B and the trending request returning 4B for the same tokens:
https://token.api.cx.metamask.io/v3/tokens/trending?chainIds=eip155%3A1,solana%3A5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp,eip155%3A56,eip155%3A8453,tron%3A728126428,eip155%3A42161,eip155%3A43114,eip155%3A137,eip155%3A59144,eip155%3A10,eip155%3A1329,eip155%3A324&sort=h24_trending&minLiquidity=200000&minVolume24hUsd=1000000&minMarketCap=0&includeRwaData=true&excludeLabels=stable_coin,blue_chip
https://token.api.cx.metamask.io/tokens/search?networks=eip155%3A1,solana%3A5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp,eip155%3A56,eip155%3A8453,tron%3A728126428,eip155%3A42161,eip155%3A43114,eip155%3A137,eip155%3A59144,eip155%3A10,eip155%3A1329,eip155%3A324&query=usdc&limit=20&includeMarketData=true&includeRwaData=true
References
https://consensyssoftware.atlassian.net/browse/ASSETS-2591
https://consensys.slack.com/archives/C03MLR70YSK/p1770117137813859
Checklist
Note
Medium Risk
Changes the default query parameters sent to the trending tokens endpoint (now including
usePriceApiData=trueand defaultingincludeRwaDataon), which can change returned market/price fields for all consumers ofgetTrendingTokens. Risk is moderate due to behavior change in an external API integration, but scope is limited to trending-token fetching.Overview
Trending token fetching now opts into price-API-backed market data by default.
getTrendingTokensandgetTrendingTokensURLadd support for a newusePriceApiDataflag (defaulting totrue) and pass it through to/v3/tokens/trending, alongside updating docs to reflect defaultincludeRwaDatabehavior.Tests were updated to expect the new
usePriceApiData=truequery param on successful trending-token requests.Written by Cursor Bugbot for commit ac3d26d. This will update automatically on new commits. Configure here.