Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
|
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2bf50c29-73a2-4537-b8b0-9dd9d8787aff |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7790 +/- ##
==========================================
- Coverage 35.08% 35.07% -0.01%
==========================================
Files 1039 1039
Lines 27633 27641 +8
Branches 2336 2336
==========================================
+ Hits 9694 9695 +1
- Misses 17416 17423 +7
Partials 523 523 ☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed! |
jpcloureiro
approved these changes
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This PR aims to implement the goerli deprecation warning.
It will only show the warning when the user it's on Goerli.
Every time the user kills the app, after hiding the warning, the warning will appear again.
This merge of this PR is blocked by the translations PR, please check if the translations are created to be included on the next release
Related issues
Fixes: #https://github.com/MetaMask/mobile-planning/issues/1369
Manual testing steps
Scenario1:
Scenario2:
Screenshots/Recordings
https://recordit.co/NBZXT6IM4L
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist