Skip to content

feat: goerli deprecation warning#7790

Merged
tommasini merged 3 commits intomainfrom
feat/1659-goerli-deprecation-warning
Nov 15, 2023
Merged

feat: goerli deprecation warning#7790
tommasini merged 3 commits intomainfrom
feat/1659-goerli-deprecation-warning

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

@tommasini tommasini commented Nov 14, 2023

Description

This PR aims to implement the goerli deprecation warning.
It will only show the warning when the user it's on Goerli.
Every time the user kills the app, after hiding the warning, the warning will appear again.

This merge of this PR is blocked by the translations PR, please check if the translations are created to be included on the next release

Related issues

Fixes: #https://github.com/MetaMask/mobile-planning/issues/1369

Manual testing steps

Scenario1:

  • Switch network to goerli
  • Hide the warning
  • Switch network to ethereum network
  • no warning should appear
  • Switch network back to goerli
  • the warning should not appear (Proposing this since it deviates from the original scenarios proposed, it was accepted here on this comment)

Scenario2:

  • Switch network to goerli
  • Hide the warning
  • Kill the app
  • Open the app
  • the warning should appear

Screenshots/Recordings

https://recordit.co/NBZXT6IM4L

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini requested a review from a team as a code owner November 14, 2023 13:25
@tommasini tommasini marked this pull request as draft November 14, 2023 13:25
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added in-progress blocked needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress blocked labels Nov 14, 2023
@tommasini tommasini marked this pull request as ready for review November 15, 2023 13:33
@github-actions
Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2bf50c29-73a2-4537-b8b0-9dd9d8787aff
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (fe361cc) 35.08% compared to head (f169677) 35.07%.

Files Patch % Lines
app/components/Nav/Main/index.js 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7790      +/-   ##
==========================================
- Coverage   35.08%   35.07%   -0.01%     
==========================================
  Files        1039     1039              
  Lines       27633    27641       +8     
  Branches     2336     2336              
==========================================
+ Hits         9694     9695       +1     
- Misses      17416    17423       +7     
  Partials      523      523              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

8.3% 8.3% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Tomas!

@tommasini tommasini merged commit ca5a673 into main Nov 15, 2023
@tommasini tommasini deleted the feat/1659-goerli-deprecation-warning branch November 15, 2023 17:34
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 15, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 15, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux Mobile UX team label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-ux Mobile UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants