Skip to content

feat: Goerli deprecation translation#7789

Merged
tommasini merged 1 commit intomainfrom
translations/1659-goerli-deprecated-warning
Nov 14, 2023
Merged

feat: Goerli deprecation translation#7789
tommasini merged 1 commit intomainfrom
translations/1659-goerli-deprecated-warning

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

@tommasini tommasini commented Nov 14, 2023 •
edited
Loading

Description

Translations for warning that deprecates goerli network
image

Related issues

Fixes: #https://github.com/MetaMask/MetaMask-planning/issues/1659

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini requested a review from a team as a code owner November 14, 2023 12:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 14, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 14, 2023
@tommasini tommasini added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 14, 2023
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tommasini tommasini mentioned this pull request Nov 14, 2023
Merged
13 tasks
@tommasini tommasini merged commit 163e338 into main Nov 14, 2023
@tommasini tommasini deleted the translations/1659-goerli-deprecated-warning branch November 14, 2023 15:06
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 14, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-platform Mobile Platform team label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees

No one assigned

Labels

release-7.12.0 Issue or pull request that will be included in release 7.12.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tommasini @NicolasMassart @gauthierpetetin @metamaskbot