Skip to content

fix: PPOM - What's New copy text refers to OpenSea previous feature - non existing in Mobile#7797

Merged
blackdevelopa merged 5 commits intomainfrom
7782/update-whatsnew-copy-blockaid
Nov 15, 2023
Merged

fix: PPOM - What's New copy text refers to OpenSea previous feature - non existing in Mobile#7797
blackdevelopa merged 5 commits intomainfrom
7782/update-whatsnew-copy-blockaid

Conversation

@blackdevelopa
Copy link
Copy Markdown
Contributor

@blackdevelopa blackdevelopa commented Nov 14, 2023 •
edited
Loading

Description

This PR updates the copy we show on the What's New modal for Blockaid. The new copy should mirror the image below. See comment for ref.

Screenshot 2023-11-13 at 13 49 17

Related issues

Fixes: #7782

Manual testing steps

  1. Include blockaid in .env
  2. Start app

Screenshots/Recordings

Before

Screenshot from 2023-11-13 17-40-26

After

Screenshot 2023-11-15 at 09 50 20

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 14, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa added the team-confirmations-secure-ux-PR PR from the confirmations team label Nov 14, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (163e338) 35.08% compared to head (3d21815) 35.08%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7797   +/-   ##
=======================================
  Coverage   35.08%   35.08%           
=======================================
  Files        1039     1039           
  Lines       27628    27628           
  Branches     2336     2336           
=======================================
  Hits         9693     9693           
  Misses      17412    17412           
  Partials      523      523

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri
Copy link
Copy Markdown
Contributor

jpuri commented Nov 14, 2023 •
edited
Loading

@blackdevelopa : this is how it looks now:

Screenshot 2023-11-14 at 11 21 17 PM

@bschorchit
Copy link
Copy Markdown
Contributor

bschorchit commented Nov 14, 2023

Looks good to me!

@blackdevelopa blackdevelopa marked this pull request as ready for review November 15, 2023 09:14
@blackdevelopa blackdevelopa requested a review from a team as a code owner November 15, 2023 09:14
@blackdevelopa blackdevelopa self-assigned this Nov 15, 2023
@blackdevelopa blackdevelopa added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 15, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 15, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/87bc6a14-5fe4-420c-81e0-0d5a3d21b08b
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

jpuri
jpuri previously approved these changes Nov 15, 2023
View reviewed changes
@blackdevelopa
Merge branch 'main' into 7782/update-whatsnew-copy-blockaid
950d8b5
@blackdevelopa
revert translations in 7782/update-whatsnew-copy-blockaid (#7824)
66e6671 
## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes: #

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@blackdevelopa blackdevelopa requested a review from jpuri November 15, 2023 13:17
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@blackdevelopa blackdevelopa merged commit b21dd22 into main Nov 15, 2023
@blackdevelopa blackdevelopa deleted the 7782/update-whatsnew-copy-blockaid branch November 15, 2023 15:16
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@cryptotavares cryptotavares cryptotavares approved these changes

+1 more reviewer

@segun segun segun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@blackdevelopa blackdevelopa

Labels

release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-confirmations-secure-ux-PR PR from the confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM - What's New copy text refers to OpenSea previous feature - non existing in Mobile

7 participants

@blackdevelopa @codecov-commenter @jpuri @bschorchit @segun @cryptotavares @metamaskbot