Skip to content

revert translations in 7782/update-whatsnew-copy-blockaid#7824

Merged
blackdevelopa merged 1 commit into7782/update-whatsnew-copy-blockaidfrom
revert-7782/translations
Nov 15, 2023
Merged

revert translations in 7782/update-whatsnew-copy-blockaid#7824
blackdevelopa merged 1 commit into7782/update-whatsnew-copy-blockaidfrom
revert-7782/translations

Conversation

@blackdevelopa
Copy link
Copy Markdown
Contributor

@blackdevelopa blackdevelopa commented Nov 15, 2023

Description

This PR reverts the code changes for the non-english copy. Another PR should handle this translation.

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@blackdevelopa blackdevelopa requested a review from a team as a code owner November 15, 2023 13:14
@blackdevelopa blackdevelopa added the team-confirmations-secure-ux-PR PR from the confirmations team label Nov 15, 2023
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa merged commit 66e6671 into 7782/update-whatsnew-copy-blockaid Nov 15, 2023
@blackdevelopa blackdevelopa deleted the revert-7782/translations branch November 15, 2023 13:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-confirmations-secure-ux-PR PR from the confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant