Skip to content

Make account details modal close button easier to click#7797

Merged
Gudahtt merged 1 commit intodevelopfrom
make-account-details-close-easier-to-click
Jan 10, 2020
Merged

Make account details modal close button easier to click#7797
Gudahtt merged 1 commit intodevelopfrom
make-account-details-close-easier-to-click

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Jan 9, 2020

The account details close button is difficult to click from the e2e tests because it has a size of zero. The actual icon is added via CSS as an ::after pseudo-element.

The CSS has been adjusted to give the icon a size, and it the markup is now a button rather than a div.

The account details close button is difficult to click from the e2e
tests because it has a size of zero. The actual icon is added via CSS
as an `::after` pseudo-element.

The CSS has been adjusted to give the icon a size, and it the markup
is now a `button` rather than a `div`.
@Gudahtt Gudahtt force-pushed the make-account-details-close-easier-to-click branch from 714f222 to 9ee7b6b Compare January 10, 2020 02:04
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [9ee7b6b]

Copy link
Copy Markdown
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@Gudahtt Gudahtt merged commit dac83f6 into develop Jan 10, 2020
@whymarrh whymarrh deleted the make-account-details-close-easier-to-click branch January 10, 2020 15:20
yqrashawn pushed a commit to yqrashawn/conflux-portal that referenced this pull request Jan 15, 2020
The account details close button is difficult to click from the e2e
tests because it has a size of zero. The actual icon is added via CSS
as an `::after` pseudo-element.

The CSS has been adjusted to give the icon a size, and it the markup
is now a `button` rather than a `div`.
yqrashawn pushed a commit to Conflux-Chain/conflux-portal that referenced this pull request Jan 15, 2020
The account details close button is difficult to click from the e2e
tests because it has a size of zero. The actual icon is added via CSS
as an `::after` pseudo-element.

The CSS has been adjusted to give the icon a size, and it the markup
is now a `button` rather than a `div`.
github-merge-queue bot pushed a commit that referenced this pull request Feb 11, 2026
…3.18.0 (#39887)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
[skip-e2e]
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
This PR bump `@metamask/assets-controllers` from `^99.0.0` to `^99.3.1`.
The current resolved version in the `yarn.lock` is `99.1.0`, which
includes a change that introduces a bug with Tempo native balances. A
fix has been released in `99.3.1`, so we need to bump to that version to
get the fix.

The cherry-pick into `13.18.0` is necessary as it includes the affected
version of `@metamask/assets-controllers`, and we don't want it to reach
production.

```markdown
## [99.3.1]

### Fixed

- Remove `Tempo Testnet` multicall address ([#7858](MetaMask/core#7858)).

## [99.3.0]

### Added

- Add optional `rwaData` support when adding tokens in `TokensController` ([#7804](MetaMask/core#7804)).

### Changed

- Lock `@metamask/core-backend` to `5.0.0` ([#7852](MetaMask/core#7852))
- Bump `@metamask/profile-sync-controller` from `^27.0.0` to `^27.1.0` ([#7849](MetaMask/core#7849))
- Fix trending tokens showing incorrect market cap values by adding `usePriceApiData` parameter (defaults to `true`) to use price API data for accurate market data ([#7829](MetaMask/core#7829))
- Bump `@metamask/transaction-controller` from `^62.13.0` to `^62.15.0` ([#7832](MetaMask/core#7832), [#7854](MetaMask/core#7854))

## [99.2.0]

### Added

- Add `HYPEREVM` support ([#7790](MetaMask/core#7790))
  - Add `HYPEREVM` in `SupportedTokenDetectionNetworks`
  - Add `HYPEREVM` in `SUPPORTED_NETWORKS_ACCOUNTS_API_V4`

### Changed

- Simplify TokenListController initialization ([#7740](MetaMask/core#7740))
- Bump `@metamask/storage-service` from `^0.0.1` to `^1.0.0` ([#7797](MetaMask/core#7797))
- Bump `@metamask/transaction-controller` from `^62.11.0` to `^62.13.0` ([#7775](MetaMask/core#7775), [#7802](MetaMask/core#7802))
- Bump `@metamask/preferences-controller` from `^22.0.0` to `^22.1.0` ([#7802](MetaMask/core#7802))

### Removed

- Removed token-search-discovery-controller package ([#7789](MetaMask/core#7789))
```

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/39887?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Dependency upgrade in a core controllers package can change
token/balance behavior and introduces transitive version shifts; risk is
mitigated by being a targeted bump intended to pick up a bugfix release.
> 
> **Overview**
> Bumps `@metamask/assets-controllers` from `^99.0.0` to `^99.3.1` and
refreshes `yarn.lock` to resolve to `99.3.1`.
> 
> Removes the Yarn patch previously applied to
`@metamask/assets-controllers@93.1.0` (and its patched exchange-rate
precision changes), relying on upstream package fixes instead; lockfile
also reflects updated transitive constraints (e.g., pinning
`@metamask/core-backend` to `5.0.0` and newer controller deps).
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
7457931. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@consensys.net>
runway-github bot added a commit that referenced this pull request Feb 11, 2026
… cp-13.18.0 (#39887)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
[skip-e2e]
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
This PR bump `@metamask/assets-controllers` from `^99.0.0` to `^99.3.1`.
The current resolved version in the `yarn.lock` is `99.1.0`, which
includes a change that introduces a bug with Tempo native balances. A
fix has been released in `99.3.1`, so we need to bump to that version to
get the fix.

The cherry-pick into `13.18.0` is necessary as it includes the affected
version of `@metamask/assets-controllers`, and we don't want it to reach
production.

```markdown
## [99.3.1]

### Fixed

- Remove `Tempo Testnet` multicall address ([#7858](MetaMask/core#7858)).

## [99.3.0]

### Added

- Add optional `rwaData` support when adding tokens in `TokensController` ([#7804](MetaMask/core#7804)).

### Changed

- Lock `@metamask/core-backend` to `5.0.0` ([#7852](MetaMask/core#7852))
- Bump `@metamask/profile-sync-controller` from `^27.0.0` to `^27.1.0` ([#7849](MetaMask/core#7849))
- Fix trending tokens showing incorrect market cap values by adding `usePriceApiData` parameter (defaults to `true`) to use price API data for accurate market data ([#7829](MetaMask/core#7829))
- Bump `@metamask/transaction-controller` from `^62.13.0` to `^62.15.0` ([#7832](MetaMask/core#7832), [#7854](MetaMask/core#7854))

## [99.2.0]

### Added

- Add `HYPEREVM` support ([#7790](MetaMask/core#7790))
  - Add `HYPEREVM` in `SupportedTokenDetectionNetworks`
  - Add `HYPEREVM` in `SUPPORTED_NETWORKS_ACCOUNTS_API_V4`

### Changed

- Simplify TokenListController initialization ([#7740](MetaMask/core#7740))
- Bump `@metamask/storage-service` from `^0.0.1` to `^1.0.0` ([#7797](MetaMask/core#7797))
- Bump `@metamask/transaction-controller` from `^62.11.0` to `^62.13.0` ([#7775](MetaMask/core#7775), [#7802](MetaMask/core#7802))
- Bump `@metamask/preferences-controller` from `^22.0.0` to `^22.1.0` ([#7802](MetaMask/core#7802))

### Removed

- Removed token-search-discovery-controller package ([#7789](MetaMask/core#7789))
```

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/39887?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Dependency upgrade in a core controllers package can change
token/balance behavior and introduces transitive version shifts; risk is
mitigated by being a targeted bump intended to pick up a bugfix release.
> 
> **Overview**
> Bumps `@metamask/assets-controllers` from `^99.0.0` to `^99.3.1` and
refreshes `yarn.lock` to resolve to `99.3.1`.
> 
> Removes the Yarn patch previously applied to
`@metamask/assets-controllers@93.1.0` (and its patched exchange-rate
precision changes), relying on upstream package fixes instead; lockfile
also reflects updated transitive constraints (e.g., pinning
`@metamask/core-backend` to `5.0.0` and newer controller deps).
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
7457931. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@consensys.net>
Prithpal-Sooriya added a commit that referenced this pull request Feb 11, 2026
…3.18.0 (#39887)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
[skip-e2e]
-->

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
This PR bump `@metamask/assets-controllers` from `^99.0.0` to `^99.3.1`.
The current resolved version in the `yarn.lock` is `99.1.0`, which
includes a change that introduces a bug with Tempo native balances. A
fix has been released in `99.3.1`, so we need to bump to that version to
get the fix.

The cherry-pick into `13.18.0` is necessary as it includes the affected
version of `@metamask/assets-controllers`, and we don't want it to reach
production.

```markdown

- Remove `Tempo Testnet` multicall address ([#7858](MetaMask/core#7858)).

- Add optional `rwaData` support when adding tokens in `TokensController` ([#7804](MetaMask/core#7804)).

- Lock `@metamask/core-backend` to `5.0.0` ([#7852](MetaMask/core#7852))
- Bump `@metamask/profile-sync-controller` from `^27.0.0` to `^27.1.0` ([#7849](MetaMask/core#7849))
- Fix trending tokens showing incorrect market cap values by adding `usePriceApiData` parameter (defaults to `true`) to use price API data for accurate market data ([#7829](MetaMask/core#7829))
- Bump `@metamask/transaction-controller` from `^62.13.0` to `^62.15.0` ([#7832](MetaMask/core#7832), [#7854](MetaMask/core#7854))

- Add `HYPEREVM` support ([#7790](MetaMask/core#7790))
  - Add `HYPEREVM` in `SupportedTokenDetectionNetworks`
  - Add `HYPEREVM` in `SUPPORTED_NETWORKS_ACCOUNTS_API_V4`

- Simplify TokenListController initialization ([#7740](MetaMask/core#7740))
- Bump `@metamask/storage-service` from `^0.0.1` to `^1.0.0` ([#7797](MetaMask/core#7797))
- Bump `@metamask/transaction-controller` from `^62.11.0` to `^62.13.0` ([#7775](MetaMask/core#7775), [#7802](MetaMask/core#7802))
- Bump `@metamask/preferences-controller` from `^22.0.0` to `^22.1.0` ([#7802](MetaMask/core#7802))

- Removed token-search-discovery-controller package ([#7789](MetaMask/core#7789))
```

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/39887?quickstart=1)

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

Fixes:

1. Go to this page...
2.
3.

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Dependency upgrade in a core controllers package can change
token/balance behavior and introduces transitive version shifts; risk is
mitigated by being a targeted bump intended to pick up a bugfix release.
>
> **Overview**
> Bumps `@metamask/assets-controllers` from `^99.0.0` to `^99.3.1` and
refreshes `yarn.lock` to resolve to `99.3.1`.
>
> Removes the Yarn patch previously applied to
`@metamask/assets-controllers@93.1.0` (and its patched exchange-rate
precision changes), relying on upstream package fixes instead; lockfile
also reflects updated transitive constraints (e.g., pinning
`@metamask/core-backend` to `5.0.0` and newer controller deps).
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
7457931. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants