Skip to content

feat(ramp): use sell get order from callback#7852

Merged
wachunei merged 1 commit intofeat/off-rampfrom
feat/ramp-use-inapp-sell-callback
Nov 16, 2023
Merged

feat(ramp): use sell get order from callback#7852
wachunei merged 1 commit intofeat/off-rampfrom
feat/ramp-use-inapp-sell-callback

Conversation

@wachunei
Copy link
Copy Markdown
Member

@wachunei wachunei commented Nov 16, 2023

Description

This PR changes for the in-app browser to use getSellOrderFromCallback on the sell flow.

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-money-movement issues related to Money Movement features labels Nov 16, 2023
@wachunei wachunei requested a review from a team as a code owner November 16, 2023 20:59
@wachunei wachunei force-pushed the feat/ramp-use-inapp-sell-callback branch from b9f5750 to 688f283 Compare November 16, 2023 21:00
@wachunei wachunei mentioned this pull request Nov 16, 2023
Merged
13 tasks
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 16, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (dbc7519) 37.11% compared to head (688f283) 37.11%.

Files Patch % Lines
...pp/components/UI/Ramp/buy/hooks/useInAppBrowser.ts 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                @@
##           feat/off-ramp    #7852      +/-   ##
=================================================
- Coverage          37.11%   37.11%   -0.01%     
=================================================
  Files               1053     1053              
  Lines              28142    28143       +1     
  Branches            2506     2507       +1     
=================================================
  Hits               10444    10444              
- Misses             17103    17104       +1     
  Partials             595      595

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 16, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 16, 2023
@wachunei wachunei merged commit 900a4e4 into feat/off-ramp Nov 16, 2023
@wachunei wachunei deleted the feat/ramp-use-inapp-sell-callback branch November 16, 2023 22:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
sethkfman
sethkfman reviewed Nov 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@georgeweiler georgeweiler georgeweiler approved these changes

+1 more reviewer

@sethkfman sethkfman sethkfman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wachunei @codecov-commenter @sethkfman @georgeweiler