Skip to content

feat(ramp): updates copy on order details page for pre-transacted orders#7858

Merged
wachunei merged 12 commits intofeat/off-rampfrom
feat/offramp-pending-order-details-copy
Nov 17, 2023
Merged

feat(ramp): updates copy on order details page for pre-transacted orders#7858
wachunei merged 12 commits intofeat/off-rampfrom
feat/offramp-pending-order-details-copy

Conversation

@georgeweiler
Copy link
Copy Markdown
Contributor

@georgeweiler georgeweiler commented Nov 17, 2023

Description

updates copy on order details page for pre-transacted orders

Related issues

n/a

Manual testing steps

n/a

Screenshots/Recordings

n/a

Before

n/a

After

n/a

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgeweiler georgeweiler requested a review from a team as a code owner November 17, 2023 00:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 17, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@wachunei wachunei mentioned this pull request Nov 17, 2023
Merged
13 tasks
wachunei
wachunei reviewed Nov 17, 2023
View reviewed changes
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 17, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (04c9dbf) 37.27% compared to head (ec7d175) 37.28%.

Files Patch % Lines
...ponents/UI/Ramp/common/components/OrderDetails.tsx 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@              Coverage Diff               @@
##           feat/off-ramp    #7858   +/-   ##
==============================================
  Coverage          37.27%   37.28%           
==============================================
  Files               1051     1051           
  Lines              28065    28071    +6     
  Branches            2512     2515    +3     
==============================================
+ Hits               10462    10467    +5     
  Misses             17005    17005           
- Partials             598      599    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wachunei
wachunei approved these changes Nov 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkirb
Copy link
Copy Markdown
Contributor

bkirb commented Nov 17, 2023

@georgeweiler LGTM I verified this change ✅

@wachunei wachunei added team-money-movement issues related to Money Movement features money-movement-qa-passed labels Nov 17, 2023
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 9 Code Smells

88.2% 88.2% Coverage
0.0% 0.0% Duplication

@bkirb
Copy link
Copy Markdown
Contributor

bkirb commented Nov 17, 2023

@georgeweiler LGTM I verified the latest commit

@wachunei wachunei merged commit 3ab6eb3 into feat/off-ramp Nov 17, 2023
@wachunei wachunei deleted the feat/offramp-pending-order-details-copy branch November 17, 2023 20:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
@sethkfman
Copy link
Copy Markdown
Contributor

sethkfman commented Nov 17, 2023

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wachunei wachunei wachunei approved these changes

Assignees

No one assigned

Labels

money-movement-qa-passed team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@georgeweiler @codecov-commenter @bkirb @sethkfman @wachunei