Skip to content

refactor(ramp): update copy for sell#7854

Merged
wachunei merged 8 commits intofeat/off-rampfrom
refactor/ramp-sell-copy-updates
Nov 17, 2023
Merged

refactor(ramp): update copy for sell#7854
wachunei merged 8 commits intofeat/off-rampfrom
refactor/ramp-sell-copy-updates

Conversation

@wachunei
Copy link
Copy Markdown
Member

@wachunei wachunei commented Nov 16, 2023

Description

This PR addresses copy updates for sell screens

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-money-movement issues related to Money Movement features needs-money-movement-qa Tickets that need feature QA on the ramps flows labels Nov 16, 2023
@wachunei wachunei mentioned this pull request Nov 16, 2023
Merged
13 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 16, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 16, 2023
@wachunei wachunei marked this pull request as ready for review November 16, 2023 22:57
@wachunei wachunei requested a review from a team as a code owner November 16, 2023 22:57
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 16, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5f94aaed-8604-4fb0-a67d-8ab97118ef2b
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@bkirb
Copy link
Copy Markdown
Contributor

bkirb commented Nov 17, 2023

@wachunei LGTM I verified the strings ✅

@bkirb
Copy link
Copy Markdown
Contributor

bkirb commented Nov 17, 2023

@wachunei I also verified the latest commit ✅

@wachunei wachunei added money-movement-qa-passed and removed needs-money-movement-qa Tickets that need feature QA on the ramps flows labels Nov 17, 2023
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

97.4% 97.4% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5dc76e5) 37.25% compared to head (a733f5f) 37.27%.

Files Patch % Lines
app/components/UI/Ramp/buy/Views/Quotes/Quotes.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                Coverage Diff                @@
##           feat/off-ramp    #7854      +/-   ##
=================================================
+ Coverage          37.25%   37.27%   +0.02%     
=================================================
  Files               1051     1051              
  Lines              28053    28065      +12     
  Branches            2501     2512      +11     
=================================================
+ Hits               10451    10462      +11     
  Misses             17005    17005              
- Partials             597      598       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wachunei wachunei merged commit 04c9dbf into feat/off-ramp Nov 17, 2023
@wachunei wachunei deleted the refactor/ramp-sell-copy-updates branch November 17, 2023 16:18
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
sethkfman
sethkfman reviewed Nov 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@georgeweiler georgeweiler georgeweiler approved these changes

+1 more reviewer

@sethkfman sethkfman sethkfman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

money-movement-qa-passed team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wachunei @bkirb @codecov-commenter @sethkfman @georgeweiler