Skip to content

Enable publish/unpublish buttons#940

Merged
swissspidy merged 5 commits intomasterfrom
bug/861-publish-and-unpublish-buttons-not-working
Apr 1, 2020
Merged

Enable publish/unpublish buttons#940
swissspidy merged 5 commits intomasterfrom
bug/861-publish-and-unpublish-buttons-not-working

Conversation

@obetomuniz
Copy link
Copy Markdown
Contributor

@obetomuniz obetomuniz commented Apr 1, 2020 •
edited by swissspidy
Loading

Fixes #861

@obetomuniz obetomuniz added the Type: Bug Something isn't working label Apr 1, 2020
@obetomuniz obetomuniz requested a review from miina April 1, 2020 15:24
@miina
Copy link
Copy Markdown
Contributor

miina commented Apr 1, 2020

@obetomuniz Let's update the tests as well for the buttons.js to ensure that saving was called and it remains with 100% test coverage. (It's probably going to fail now anyway.)

@obetomuniz
Merge branch 'master' into bug/861-publish-and-unpublish-buttons-not-…
d015258 
…working

* master: (50 commits)
  Update react-moveable and disable snap digits again (#941)
  Template Animation: Added move and repeater animation (#618) (#881)
  Fix storybook hierarchy (#939)
  Fix spinner / progress bar when saving (#937)
  Change placeholder text for pre-publish panel (#934)
  Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931)
  Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932)
  Fix Document panel crashing (#930)
  Fix deployment (#928)
  Update URL when publishing post. (#836)
  Fix multiple warnings and proptype issues (#929)
  Added scroll behavior to layer panel when reordering by mouse (#551)
  Fix forms events in Firefox (#875)
  Add save story error message (#888)
  lints
  fixed tests
  font size calculations fixed
  Use native aspect-ration format for grid layers
  Fixed behavior for selected elements (#924)
  Fix ID prefix in auto-advanve-after (#915)
  ...
barklund
barklund suggested changes Apr 1, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@barklund barklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for simplifying the code. Also, needs testing!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2020 •
edited
Loading

Size Change: +1.41 kB (0%)

Total Size: 512 kB

Filename Size Change
assets/js/edit-story.js 440 kB +507 B (0%)
assets/js/stories-dashboard.js 68.2 kB +902 B (1%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 3.01 kB 0 B
assets/css/stories-dashboard.css 206 B 0 B

compressed-size-action

@obetomuniz obetomuniz requested a review from barklund April 1, 2020 17:51
barklund
barklund approved these changes Apr 1, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@barklund barklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obetomuniz obetomuniz requested a review from spacedmonkey as a code owner April 1, 2020 19:21
@swissspidy swissspidy merged commit aa1a28a into master Apr 1, 2020
@swissspidy swissspidy deleted the bug/861-publish-and-unpublish-buttons-not-working branch April 1, 2020 21:16
obetomuniz added a commit that referenced this pull request Apr 1, 2020
@obetomuniz
Merge branch 'master' into bug/alert-user-before-exit-window
8ff3afe 
* master:
  Fixes a couple of bugs surrounding text edit component and colors. (#955)
  Enable publish/unpublish buttons (#940)
  Bump @wordpress/scripts from 7.1.3 to 7.2.0 (#952)
  Bump @wordpress/e2e-test-utils from 4.3.1 to 4.4.0 (#953)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

@dvoytenko dvoytenko Awaiting requested review from dvoytenko

@miina miina Awaiting requested review from miina

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

+2 more reviewers

@ndev1991 ndev1991 ndev1991 left review comments

@barklund barklund barklund approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Type: Bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Publish" and "Switch to Draft" button not updating the DB

6 participants

@obetomuniz @miina @barklund @swissspidy @ndev1991 @googlebot