Skip to content

Fix multiple warnings and proptype issues#929

Merged
wassgha merged 2 commits intomasterfrom
warnings-fix
Apr 1, 2020
Merged

Fix multiple warnings and proptype issues#929
wassgha merged 2 commits intomasterfrom
warnings-fix

Conversation

@wassgha
Copy link
Copy Markdown
Contributor

@wassgha wassgha commented Apr 1, 2020

Closes #381
Closes #807

Changes

  • Fixes multiple missing defaults (scale, focalX, focalY, isFill) and preserve them when using drop targets on an existing element
  • Fixes PropType mismatch coming from Video cropping + media elements refactor #524
  • Fixes warning about WithMasks missing children

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2020

Size Change: +1.05 kB (0%)

Total Size: 510 kB

Filename Size Change
assets/js/edit-story.js 439 kB +1.05 kB (0%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 3.01 kB 0 B
assets/css/stories-dashboard.css 206 B 0 B
assets/js/stories-dashboard.js 67.3 kB 0 B

compressed-size-action

@swissspidy
Copy link
Copy Markdown
Collaborator

Possibly fixes #807 and #381.

@wassgha
Copy link
Copy Markdown
Contributor Author

wassgha commented Apr 1, 2020

@swissspidy verified that it does

@wassgha wassgha merged commit f688826 into master Apr 1, 2020
@wassgha wassgha deleted the warnings-fix branch April 1, 2020 07:56
@swissspidy swissspidy added the Type: Bug Something isn't working label Apr 1, 2020
obetomuniz added a commit that referenced this pull request Apr 1, 2020
* master: (61 commits)
  Change placeholder text for pre-publish panel (#934)
  Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931)
  Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932)
  Fix Document panel crashing (#930)
  Fix deployment (#928)
  Update URL when publishing post. (#836)
  Fix multiple warnings and proptype issues (#929)
  Added scroll behavior to layer panel when reordering by mouse (#551)
  Fix forms events in Firefox (#875)
  Add save story error message (#888)
  lints
  fixed tests
  font size calculations fixed
  Use native aspect-ration format for grid layers
  Fixed behavior for selected elements (#924)
  Fix ID prefix in auto-advanve-after (#915)
  Review fixes
  Switch to using Resource object throughout. Fix related bugs.
  Bump uuid from 7.0.2 to 7.0.3 (#913)
  Use Resource type everywhere relevant
  ...
obetomuniz added a commit that referenced this pull request Apr 1, 2020
…working

* master: (50 commits)
  Update react-moveable and disable snap digits again (#941)
  Template Animation: Added move and repeater animation (#618) (#881)
  Fix storybook hierarchy (#939)
  Fix spinner / progress bar when saving (#937)
  Change placeholder text for pre-publish panel (#934)
  Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931)
  Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932)
  Fix Document panel crashing (#930)
  Fix deployment (#928)
  Update URL when publishing post. (#836)
  Fix multiple warnings and proptype issues (#929)
  Added scroll behavior to layer panel when reordering by mouse (#551)
  Fix forms events in Firefox (#875)
  Add save story error message (#888)
  lints
  fixed tests
  font size calculations fixed
  Use native aspect-ration format for grid layers
  Fixed behavior for selected elements (#924)
  Fix ID prefix in auto-advanve-after (#915)
  ...
obetomuniz added a commit that referenced this pull request Apr 1, 2020
* master: (56 commits)
  Add Snackbar for Invalid Links. (#912)
  Renamed files to make more sense, updated aria-label.
  Finished initial pass on Dashboard My Stories Page UI Grid View
  Update react-moveable and disable snap digits again (#941)
  Template Animation: Added move and repeater animation (#618) (#881)
  Fix storybook hierarchy (#939)
  Fix spinner / progress bar when saving (#937)
  Change placeholder text for pre-publish panel (#934)
  Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931)
  Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932)
  Fix Document panel crashing (#930)
  Fix deployment (#928)
  Update URL when publishing post. (#836)
  Fix multiple warnings and proptype issues (#929)
  Added scroll behavior to layer panel when reordering by mouse (#551)
  Fix forms events in Firefox (#875)
  Add save story error message (#888)
  lints
  fixed tests
  font size calculations fixed
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Various console log errors for Media elements Prop types errors surrounding masks

3 participants