Merged
Conversation
Contributor
|
Size Change: +1 B Total Size: 510 kB
ℹ️ View Unchanged
|
swissspidy
approved these changes
Apr 1, 2020
Contributor
|
See #803 for a refactor, I don't think we need the parent node at all |
obetomuniz
added a commit
that referenced
this pull request
Apr 1, 2020
* master: (61 commits) Change placeholder text for pre-publish panel (#934) Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931) Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932) Fix Document panel crashing (#930) Fix deployment (#928) Update URL when publishing post. (#836) Fix multiple warnings and proptype issues (#929) Added scroll behavior to layer panel when reordering by mouse (#551) Fix forms events in Firefox (#875) Add save story error message (#888) lints fixed tests font size calculations fixed Use native aspect-ration format for grid layers Fixed behavior for selected elements (#924) Fix ID prefix in auto-advanve-after (#915) Review fixes Switch to using Resource object throughout. Fix related bugs. Bump uuid from 7.0.2 to 7.0.3 (#913) Use Resource type everywhere relevant ...
obetomuniz
added a commit
that referenced
this pull request
Apr 1, 2020
…working * master: (50 commits) Update react-moveable and disable snap digits again (#941) Template Animation: Added move and repeater animation (#618) (#881) Fix storybook hierarchy (#939) Fix spinner / progress bar when saving (#937) Change placeholder text for pre-publish panel (#934) Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931) Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932) Fix Document panel crashing (#930) Fix deployment (#928) Update URL when publishing post. (#836) Fix multiple warnings and proptype issues (#929) Added scroll behavior to layer panel when reordering by mouse (#551) Fix forms events in Firefox (#875) Add save story error message (#888) lints fixed tests font size calculations fixed Use native aspect-ration format for grid layers Fixed behavior for selected elements (#924) Fix ID prefix in auto-advanve-after (#915) ...
obetomuniz
added a commit
that referenced
this pull request
Apr 1, 2020
* master: (56 commits) Add Snackbar for Invalid Links. (#912) Renamed files to make more sense, updated aria-label. Finished initial pass on Dashboard My Stories Page UI Grid View Update react-moveable and disable snap digits again (#941) Template Animation: Added move and repeater animation (#618) (#881) Fix storybook hierarchy (#939) Fix spinner / progress bar when saving (#937) Change placeholder text for pre-publish panel (#934) Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931) Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932) Fix Document panel crashing (#930) Fix deployment (#928) Update URL when publishing post. (#836) Fix multiple warnings and proptype issues (#929) Added scroll behavior to layer panel when reordering by mouse (#551) Fix forms events in Firefox (#875) Add save story error message (#888) lints fixed tests font size calculations fixed ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a quick fix for document panel not crashing after merging #551 , however, it would be good to see if there is a better way how to fix this in the context of the full PR (perhaps it's OK as it is), and also add a test to ensure the tabs work as expected.