Skip to content

Fixed behavior for selected elements#924

Merged
wassgha merged 3 commits intomasterfrom
selection/drop-targets
Apr 1, 2020
Merged

Fixed behavior for selected elements#924
wassgha merged 3 commits intomasterfrom
selection/drop-targets

Conversation

@wassgha
Copy link
Copy Markdown
Contributor

@wassgha wassgha commented Apr 1, 2020

Closes #920

Changes

  • While dragging, only hide selection box for maskable elements (fixes behavior where text selection box was hidden and snap lines appeared out of context)
  • Hide selection box for drop targets to clearly show which elements are drop targets
  • Removes need for rectangular masks in output (Optimize by not outputting rect mask in each case #920)
  • Minor cleanups and consolidation of variables

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2020

Size Change: -78 B (0%)

Total Size: 507 kB

Filename Size Change
assets/js/edit-story.js 437 kB -78 B (0%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 3.01 kB 0 B
assets/css/stories-dashboard.css 206 B 0 B
assets/js/stories-dashboard.js 67.3 kB 0 B

compressed-size-action

@wassgha wassgha requested a review from pbakaus as a code owner April 1, 2020 01:45
@wassgha wassgha requested a review from dvoytenko April 1, 2020 01:48
@wassgha wassgha merged commit b7b2aa2 into master Apr 1, 2020
@wassgha wassgha deleted the selection/drop-targets branch April 1, 2020 01:58
obetomuniz added a commit that referenced this pull request Apr 1, 2020
* master: (61 commits)
  Change placeholder text for pre-publish panel (#934)
  Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931)
  Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932)
  Fix Document panel crashing (#930)
  Fix deployment (#928)
  Update URL when publishing post. (#836)
  Fix multiple warnings and proptype issues (#929)
  Added scroll behavior to layer panel when reordering by mouse (#551)
  Fix forms events in Firefox (#875)
  Add save story error message (#888)
  lints
  fixed tests
  font size calculations fixed
  Use native aspect-ration format for grid layers
  Fixed behavior for selected elements (#924)
  Fix ID prefix in auto-advanve-after (#915)
  Review fixes
  Switch to using Resource object throughout. Fix related bugs.
  Bump uuid from 7.0.2 to 7.0.3 (#913)
  Use Resource type everywhere relevant
  ...
obetomuniz added a commit that referenced this pull request Apr 1, 2020
…working

* master: (50 commits)
  Update react-moveable and disable snap digits again (#941)
  Template Animation: Added move and repeater animation (#618) (#881)
  Fix storybook hierarchy (#939)
  Fix spinner / progress bar when saving (#937)
  Change placeholder text for pre-publish panel (#934)
  Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931)
  Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932)
  Fix Document panel crashing (#930)
  Fix deployment (#928)
  Update URL when publishing post. (#836)
  Fix multiple warnings and proptype issues (#929)
  Added scroll behavior to layer panel when reordering by mouse (#551)
  Fix forms events in Firefox (#875)
  Add save story error message (#888)
  lints
  fixed tests
  font size calculations fixed
  Use native aspect-ration format for grid layers
  Fixed behavior for selected elements (#924)
  Fix ID prefix in auto-advanve-after (#915)
  ...
@swissspidy swissspidy added the Type: Bug Something isn't working label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize by not outputting rect mask in each case

4 participants