Skip to content

Fix spinner / progress bar when saving#937

Merged
swissspidy merged 3 commits intomasterfrom
fix/loading-spinner
Apr 1, 2020
Merged

Fix spinner / progress bar when saving#937
swissspidy merged 3 commits intomasterfrom
fix/loading-spinner

Conversation

@swissspidy
Copy link
Copy Markdown
Collaborator

Screenshot:
Screenshot 2020-04-01 at 15 50 50

Note: this does not change any existing loading indicator. There was no working loading indicator before.

Fixes #856
Fixes #790

@swissspidy swissspidy added the Type: Bug Something isn't working label Apr 1, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2020

Size Change: +226 B (0%)

Total Size: 510 kB

Filename Size Change
assets/js/edit-story.js 440 kB +226 B (0%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 3.01 kB 0 B
assets/css/stories-dashboard.css 206 B 0 B
assets/js/stories-dashboard.js 67.3 kB 0 B

compressed-size-action

@swissspidy
Copy link
Copy Markdown
Collaborator Author

FWIW, actual page size will be much smaller because the wordpress/components script won't be loaded.

@swissspidy swissspidy requested review from miina and spacedmonkey April 1, 2020 14:08
Copy link
Copy Markdown
Contributor

@miina miina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@swissspidy swissspidy merged commit b057ae7 into master Apr 1, 2020
@swissspidy swissspidy deleted the fix/loading-spinner branch April 1, 2020 15:16
obetomuniz added a commit that referenced this pull request Apr 1, 2020
…working

* master: (50 commits)
  Update react-moveable and disable snap digits again (#941)
  Template Animation: Added move and repeater animation (#618) (#881)
  Fix storybook hierarchy (#939)
  Fix spinner / progress bar when saving (#937)
  Change placeholder text for pre-publish panel (#934)
  Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931)
  Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932)
  Fix Document panel crashing (#930)
  Fix deployment (#928)
  Update URL when publishing post. (#836)
  Fix multiple warnings and proptype issues (#929)
  Added scroll behavior to layer panel when reordering by mouse (#551)
  Fix forms events in Firefox (#875)
  Add save story error message (#888)
  lints
  fixed tests
  font size calculations fixed
  Use native aspect-ration format for grid layers
  Fixed behavior for selected elements (#924)
  Fix ID prefix in auto-advanve-after (#915)
  ...
obetomuniz added a commit that referenced this pull request Apr 1, 2020
* master: (56 commits)
  Add Snackbar for Invalid Links. (#912)
  Renamed files to make more sense, updated aria-label.
  Finished initial pass on Dashboard My Stories Page UI Grid View
  Update react-moveable and disable snap digits again (#941)
  Template Animation: Added move and repeater animation (#618) (#881)
  Fix storybook hierarchy (#939)
  Fix spinner / progress bar when saving (#937)
  Change placeholder text for pre-publish panel (#934)
  Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931)
  Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932)
  Fix Document panel crashing (#930)
  Fix deployment (#928)
  Update URL when publishing post. (#836)
  Fix multiple warnings and proptype issues (#929)
  Added scroll behavior to layer panel when reordering by mouse (#551)
  Fix forms events in Firefox (#875)
  Add save story error message (#888)
  lints
  fixed tests
  font size calculations fixed
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spinner unstyled: displays in HTML but not visible for the user Custom Loading Indicator component

3 participants