Conversation
|
Size Change: +171 B (0%) Total Size: 506 kB
ℹ️ View Unchanged
|
|
Doesn't the snackbar provider support various positions? cc @ndev1991 Would need UX confirmation on best position |
It does, but only at Provider level (cannot be overridden for a specific snackbar), so this should be changed IMHO. <SnackbarProvider place="top-right">CC @samitron7 for UX
|
|
The code for this looks good ( it is very simple ). Once UX has been confirmed, I will approve. |
|
The Material recommendation is for snackbar to always be at the bottom lower left corner. It's definitely not ideal and we're looking slightly changing up the notification system in P1 but in the meantime, I would go with the Material recommendation.
|
|
@spacedmonkey Let's merge it for Alpha. |
|
@merapi Approved |
barklund
left a comment
There was a problem hiding this comment.
I'd like us to give better feedback, in order for users of the plugin to file better bug reports.
| .catch(() => { | ||
| // TODO Display error message to user as save as failed. | ||
| showSnackbar({ | ||
| message: __('Failed to save the story', 'web-stories'), |
There was a problem hiding this comment.
Should we include some extra technical information? If a superuser wants to try to do something about it, they need more info. Or if any of our alpha/beta testers come across this, they need more information in order to file a better bug report.
Can we add extra info to the snack bar, that can be expanded, or something like that? Something like a "Show technical information" toggle?
There was a problem hiding this comment.
I also think that we can follow up on this after.
dvoytenko
left a comment
There was a problem hiding this comment.
LGTM. Would also like to see a follow up with some user-actionable messaging. Such as "Try again.". Assuming we can tell the reason for why saving fails.
|
@jauyong Can you create a follow-up task for more actionable messaging here? |
* master: (61 commits) Change placeholder text for pre-publish panel (#934) Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931) Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932) Fix Document panel crashing (#930) Fix deployment (#928) Update URL when publishing post. (#836) Fix multiple warnings and proptype issues (#929) Added scroll behavior to layer panel when reordering by mouse (#551) Fix forms events in Firefox (#875) Add save story error message (#888) lints fixed tests font size calculations fixed Use native aspect-ration format for grid layers Fixed behavior for selected elements (#924) Fix ID prefix in auto-advanve-after (#915) Review fixes Switch to using Resource object throughout. Fix related bugs. Bump uuid from 7.0.2 to 7.0.3 (#913) Use Resource type everywhere relevant ...
…working * master: (50 commits) Update react-moveable and disable snap digits again (#941) Template Animation: Added move and repeater animation (#618) (#881) Fix storybook hierarchy (#939) Fix spinner / progress bar when saving (#937) Change placeholder text for pre-publish panel (#934) Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931) Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932) Fix Document panel crashing (#930) Fix deployment (#928) Update URL when publishing post. (#836) Fix multiple warnings and proptype issues (#929) Added scroll behavior to layer panel when reordering by mouse (#551) Fix forms events in Firefox (#875) Add save story error message (#888) lints fixed tests font size calculations fixed Use native aspect-ration format for grid layers Fixed behavior for selected elements (#924) Fix ID prefix in auto-advanve-after (#915) ...
* master: (56 commits) Add Snackbar for Invalid Links. (#912) Renamed files to make more sense, updated aria-label. Finished initial pass on Dashboard My Stories Page UI Grid View Update react-moveable and disable snap digits again (#941) Template Animation: Added move and repeater animation (#618) (#881) Fix storybook hierarchy (#939) Fix spinner / progress bar when saving (#937) Change placeholder text for pre-publish panel (#934) Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931) Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932) Fix Document panel crashing (#930) Fix deployment (#928) Update URL when publishing post. (#836) Fix multiple warnings and proptype issues (#929) Added scroll behavior to layer panel when reordering by mouse (#551) Fix forms events in Firefox (#875) Add save story error message (#888) lints fixed tests font size calculations fixed ...
Fixes #801
However, I don't know if this is enough for such critical action.
On FHD it's barely noticeable, given the distance between button and message:
