Conversation
|
Size Change: +3.19 kB (0%) Total Size: 510 kB
ℹ️ View Unchanged
|
|
/cc @samitron7 |
| if (!isValidUrl(urlWithProtocol)) { | ||
| return; | ||
| } | ||
| const invalidLinkMessage = __('This is an invalid link!', 'web-stories'); |
There was a problem hiding this comment.
Just "This"? Maybe we should show the url in the snackbar too?
const invalidLinkMessage = __('The following is not a valid link: %s', 'web-stories');And then:
showSnackbar({
message: sprintf(invalidLinkMessage, url),
});There was a problem hiding this comment.
Sure! I will update.
There was a problem hiding this comment.
Is it the expected result @barklund ? What about that blank space?
There was a problem hiding this comment.
Looks good to me, but perhaps validate with @pbakaus or @samitron7.
There was a problem hiding this comment.
I don't really like the URL there tbh, feels uncessary and makes the tooltip bigger than it should be
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
One note: with the dark theme that we have in the editor, I didn't even notice the Snackbar message at all until I started looking for it specifically since I knew it had to come with the PR. UX question: Could the Snackbar message perhaps be closer to the link or be with a different color to stand out from the dark theme? The location of the Snackbar is a bit risky since it's on top of Media (at least on my screen) and the images below that could disguise it well -- that's not in our control what kind of images the user has. Not sure the current messaging is accessible in terms of being visually well noticeable especially while the focus of the user is on the link area of the editor (the opposite side). Thoughts? |
|
@obetomuniz The PHP tests seem to need an update as well. Can do that in a bit. |
* master: (56 commits) Add Snackbar for Invalid Links. (#912) Renamed files to make more sense, updated aria-label. Finished initial pass on Dashboard My Stories Page UI Grid View Update react-moveable and disable snap digits again (#941) Template Animation: Added move and repeater animation (#618) (#881) Fix storybook hierarchy (#939) Fix spinner / progress bar when saving (#937) Change placeholder text for pre-publish panel (#934) Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931) Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932) Fix Document panel crashing (#930) Fix deployment (#928) Update URL when publishing post. (#836) Fix multiple warnings and proptype issues (#929) Added scroll behavior to layer panel when reordering by mouse (#551) Fix forms events in Firefox (#875) Add save story error message (#888) lints fixed tests font size calculations fixed ...
Fixes #806