Conversation
|
Size Change: +336 B (0%) Total Size: 510 kB
ℹ️ View Unchanged
|
barklund
left a comment
There was a problem hiding this comment.
A few comments, mostly on test
spacedmonkey
left a comment
There was a problem hiding this comment.
One quick question, otherwise this looks good.
|
It's odd that hitting "Publish" merely changes the status in the editor but doesn't actually save the story until I click "Update". The URL is updated, but I still lose all changes when reloading the page. |
|
Do you mean changing the post status? I am not sure what the expected behaviour should be here. |
Hmm, that's a good point, it should use saving the Story and not just update the state. Will check if I can add this quickly. |
|
I am not sure from a UI state point this is good. Changing the post visibility does not publish the post in gutenberg. It shouldn't do so here either. Clicking a update / publish button is clear you making a story public. Changing the visibility is not. |
The discussion is about the "Publish" button -- it's currently not publishing the post until "Update" is also clicked. The visibility is a different case and that should only change in case of clicking "Update". |
|
@swissspidy Actually, let's create a separate issue for that, it should also "Switch to Draft" without having to Save Draft as well, currently, it's not doing that either. Ideally, "Publish" button would have a confirmation as well then, I suppose? Anyway -- let's create a separate issue to track the instant status change with the buttons and get this issue specific to the URL merged separately. Thoughts? |
|
Good points! Makes sense to me |
|
Follow-up issue: #861 |
|
@miina Can you resolve the conflict here? |
Outdated review / points have been addressed
|
Another conflict emerged 😥 |
|
Resolved. |
|
Thanks! Merged now, but needs #861 soon-ish. |
* master: (61 commits) Change placeholder text for pre-publish panel (#934) Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931) Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932) Fix Document panel crashing (#930) Fix deployment (#928) Update URL when publishing post. (#836) Fix multiple warnings and proptype issues (#929) Added scroll behavior to layer panel when reordering by mouse (#551) Fix forms events in Firefox (#875) Add save story error message (#888) lints fixed tests font size calculations fixed Use native aspect-ration format for grid layers Fixed behavior for selected elements (#924) Fix ID prefix in auto-advanve-after (#915) Review fixes Switch to using Resource object throughout. Fix related bugs. Bump uuid from 7.0.2 to 7.0.3 (#913) Use Resource type everywhere relevant ...
…working * master: (50 commits) Update react-moveable and disable snap digits again (#941) Template Animation: Added move and repeater animation (#618) (#881) Fix storybook hierarchy (#939) Fix spinner / progress bar when saving (#937) Change placeholder text for pre-publish panel (#934) Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931) Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932) Fix Document panel crashing (#930) Fix deployment (#928) Update URL when publishing post. (#836) Fix multiple warnings and proptype issues (#929) Added scroll behavior to layer panel when reordering by mouse (#551) Fix forms events in Firefox (#875) Add save story error message (#888) lints fixed tests font size calculations fixed Use native aspect-ration format for grid layers Fixed behavior for selected elements (#924) Fix ID prefix in auto-advanve-after (#915) ...
* master: (56 commits) Add Snackbar for Invalid Links. (#912) Renamed files to make more sense, updated aria-label. Finished initial pass on Dashboard My Stories Page UI Grid View Update react-moveable and disable snap digits again (#941) Template Animation: Added move and repeater animation (#618) (#881) Fix storybook hierarchy (#939) Fix spinner / progress bar when saving (#937) Change placeholder text for pre-publish panel (#934) Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931) Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932) Fix Document panel crashing (#930) Fix deployment (#928) Update URL when publishing post. (#836) Fix multiple warnings and proptype issues (#929) Added scroll behavior to layer panel when reordering by mouse (#551) Fix forms events in Firefox (#875) Add save story error message (#888) lints fixed tests font size calculations fixed ...
Fixes #697