Skip to content

Video cropping + media elements refactor#524

Merged
swissspidy merged 11 commits intomasterfrom
add/442-video-edit
Mar 11, 2020
Merged

Video cropping + media elements refactor#524
swissspidy merged 11 commits intomasterfrom
add/442-video-edit

Conversation

@miina
Copy link
Copy Markdown
Contributor

@miina miina commented Mar 10, 2020

Fixes #442

  • Bring cropping (resizing in edit mode) to Video element.
  • Reuses logic between media elements.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 10, 2020

Size Change: +5.11 kB (1%)

Total Size: 398 kB

Filename Size Change
assets/js/edit-story.js 357 kB +5.11 kB (1%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 189 B 0 B
assets/css/stories-dashboard.css 165 B 0 B
assets/js/stories-dashboard.js 40.9 kB 0 B

compressed-size-action

@swissspidy swissspidy added the Type: Enhancement New feature or improvement of an existing feature label Mar 10, 2020
@miina miina changed the title [WIP] Video cropping + media elements refactor Video cropping + media elements refactor Mar 11, 2020
@miina miina marked this pull request as ready for review March 11, 2020 08:38
@spacedmonkey
Copy link
Copy Markdown
Contributor

@miina Unit tests are failing.

@miina
Copy link
Copy Markdown
Contributor Author

miina commented Mar 11, 2020

@spacedmonkey Thanks, the tests are passing now.

@swissspidy swissspidy self-requested a review March 11, 2020 11:41
Copy link
Copy Markdown
Contributor

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Enhancement New feature or improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Video - Add features from Images

4 participants