Skip to content

Fixes a couple of bugs surrounding text edit component and colors.#955

Merged
swissspidy merged 1 commit intomasterfrom
bug/944-945-text-edit
Apr 1, 2020
Merged

Fixes a couple of bugs surrounding text edit component and colors.#955
swissspidy merged 1 commit intomasterfrom
bug/944-945-text-edit

Conversation

@barklund
Copy link
Copy Markdown
Contributor

@barklund barklund commented Apr 1, 2020

Fixes #944 by defaulting color to be white-on-black when editing a highlight-text node.

Fixes #945 by always removing the background when text fill mode is set to NONE.

Fixes #944 by defaulting color to be white-on-black when editing a highlight-text node.

Fixes #945 by always removing the background when text fill mode is set to `NONE`.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2020

Size Change: +22 B (0%)

Total Size: 513 kB

Filename Size Change
assets/js/edit-story.js 440 kB +22 B (0%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 3.01 kB 0 B
assets/css/stories-dashboard.css 206 B 0 B
assets/js/stories-dashboard.js 69.3 kB 0 B

compressed-size-action

@swissspidy swissspidy merged commit be76190 into master Apr 1, 2020
@swissspidy swissspidy deleted the bug/944-945-text-edit branch April 1, 2020 22:23
obetomuniz added a commit that referenced this pull request Apr 1, 2020
* master:
  Fixes a couple of bugs surrounding text edit component and colors. (#955)
  Enable publish/unpublish buttons (#940)
  Bump @wordpress/scripts from 7.1.3 to 7.2.0 (#952)
  Bump @wordpress/e2e-test-utils from 4.3.1 to 4.4.0 (#953)
@swissspidy swissspidy added the Type: Bug Something isn't working label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text background color shown in edit mode despite being disabled Text - Default Colour - Edit Mode

4 participants