Skip to content

Release candidate : v1.84.0#5334

Merged
siddhartha-quad merged 33 commits into
mainfrom
release-candidate
Mar 12, 2026
Merged

Release candidate : v1.84.0#5334
siddhartha-quad merged 33 commits into
mainfrom
release-candidate

Conversation

@siddhartha-quad

Copy link
Copy Markdown
Contributor

Release candidate : v1.84.0

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

dependabot Bot and others added 30 commits February 10, 2026 00:35
Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.16.4 to 5.16.5.
- [Release notes](https://github.com/go-git/go-git/releases)
- [Commits](go-git/go-git@v5.16.4...v5.16.5)

---
updated-dependencies:
- dependency-name: github.com/go-git/go-git/v5
  dependency-version: 5.16.5
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl) from 1.6.1 to 1.6.3.
- [Release notes](https://github.com/cloudflare/circl/releases)
- [Commits](cloudflare/circl@v1.6.1...v1.6.3)

---
updated-dependencies:
- dependency-name: github.com/cloudflare/circl
  dependency-version: 1.6.3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…fe (#5316)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aslam <aslmohammad@google.com>
@siddhartha-quad siddhartha-quad added the release-chore To not include into release notes label Mar 11, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request prepares the repository for the v1.84.0 release candidate. It primarily focuses on updating internal and external dependencies, bumping version numbers across various components, and enhancing the stability and functionality of the toolkit. Key improvements include updated GKE and Terraform provider versions, refinements to machine learning examples, and the introduction of new validation and release management tools. These changes collectively aim to ensure compatibility with the latest cloud services and streamline development and testing workflows.

Highlights

  • Version Updates: The core toolkit version has been bumped to v1.84.0 across the application and various Terraform modules. Several GKE example blueprints and the gpu_direct.tf module have updated their recommended or required GKE versions to newer releases. The hashicorp/google and hashicorp/google-beta Terraform provider versions have been updated to support up to 7.21.0.
  • Dependency & Example Refinements: The django-allauth Python dependency was updated to 65.14.1. Go module dependencies for go-git/go-git/v5 and cloudflare/circl were also updated. The ml-slurm-g4.yaml example now uses a different Ubuntu accelerator image, a newer Slurm git reference (6.10.10), and an updated CUDA toolkit (12-9), along with simplified NVIDIA driver installation. The import_pytorch_container.sh script was enhanced to handle XDG_RUNTIME_DIR for non-interactive shells.
  • New Validator and Refactoring: A new test_disk_type_in_zone validator has been introduced to verify disk type availability. The existing testMachineTypeInZoneAvailability validator was refactored to use a new generic helper function, testResourceInZoneAvailability, improving code reusability and maintainability for resource validation.
  • New Utility Scripts: Two new utility scripts were added: tools/add_ttl_label.sh to automatically add or update a time-to-live label in blueprint YAML files, and tools/publish_release.sh to manage release manifest uploads to GCS.
  • Cleanup Script Enhancements: The tools/cleanup.sh script was updated to include logic for protecting and processing Managed Lustre instances, ensuring their associated networks are also handled correctly during cleanup operations.
  • Cloud Build Integration: Numerous Cloud Build daily test configurations were updated to integrate the new tools/add_ttl_label.sh script, ensuring that blueprints deployed during automated tests automatically receive a time-to-live label for better resource management.
Changelog
  • cmd/root.go
    • Updated the application version string to v1.84.0.
  • community/front-end/ofe/requirements.txt
    • Updated django-allauth from 65.14.0 to 65.14.1.
  • community/modules/compute/gke-nodeset/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/compute/gke-partition/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/compute/htcondor-execute-point/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/compute/mig/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/compute/schedmd-slurm-gcp-v6-nodeset-dynamic/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/compute/schedmd-slurm-gcp-v6-nodeset-tpu/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/compute/schedmd-slurm-gcp-v6-nodeset/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/compute/schedmd-slurm-gcp-v6-partition/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/database/slurm-cloudsql-federation/versions.tf
    • Updated module_name versions for google and google-beta providers to v1.84.0.
  • community/modules/file-system/nfs-server/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/files/fsi-montecarlo-on-batch/versions.tf
    • Updated module_name versions for google and google-beta providers to v1.84.0.
  • community/modules/internal/slurm-gcp/login/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/project/service-enablement/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/pubsub/bigquery-sub/versions.tf
    • Updated module_name versions for google and google-beta providers to v1.84.0.
  • community/modules/pubsub/topic/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/scheduler/htcondor-access-point/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/scheduler/htcondor-central-manager/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/scheduler/htcondor-pool-secrets/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/scheduler/schedmd-slurm-gcp-v6-controller/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/scheduler/schedmd-slurm-gcp-v6-login/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/scripts/wait-for-startup/versions.tf
    • Updated module_name version to v1.84.0.
  • community/modules/scripts/windows-startup-script/versions.tf
    • Updated module_name version to v1.84.0.
  • docs/blueprint-validation.md
    • Added documentation for the new test_disk_type_in_zone validator.
  • examples/gke-a4x-max-bm/README.md
    • Updated the recommended GKE version for A4X-Max support to 1.34.3-gke.1318000.
  • examples/gke-consumption-options/dws-flex-start/gke-tpu-7x/README.md
    • Updated GKE version references in example output to v1.34.3-gke.1318000.
  • examples/gke-consumption-options/dws-flex-start/gke-tpu-v6e/README.md
    • Updated GKE version references in example output to v1.33.5-gke.2392000.
  • examples/gke-g4/README.md
    • Updated the required GKE version for G4 support to >= 1.32.11-gke.1174000.
  • examples/gke-h4d/README.md
    • Updated the required GKE version for H4D support to >= 1.32.11-gke.1174000.
  • examples/gke-tpu-7x/README.md
    • Updated the minimum GKE version requirement for Cloud TPU 7x to 1.34.3-gke.1318000 or later.
  • examples/machine-learning/a3-highgpu-8g/nccl-tests/import_pytorch_container.sh
    • Added logic to set XDG_RUNTIME_DIR for non-interactive shells.
    • Updated comment regarding the nvidia+pytorch version.
  • examples/ml-slurm-g4.yaml
    • Updated comments for project_id and deployment_name.
    • Changed source_image_family to ubuntu-accelerator-2204-amd64-with-nvidia-580 and source_image_project to ubuntu-os-accelerator-images.
    • Updated build_slurm_from_git_ref to 6.10.10.
    • Removed specific NVIDIA driver packages and added cuda-toolkit-12-9.
    • Removed the task for removing conflicting Ubuntu NVIDIA firmware.
    • Removed dpkg_options: 'force-overwrite' from NVIDIA package installation.
  • go.mod
    • Updated github.com/go-git/go-git/v5 from v5.16.4 to v5.16.5.
    • Updated github.com/cloudflare/circl from v1.6.1 to v1.6.3.
  • go.sum
    • Updated checksums for github.com/cloudflare/circl and github.com/go-git/go-git/v5.
  • modules/compute/gke-node-pool/gpu_direct.tf
    • Updated acceptable GKE versions for a2-ultragpu-8g and a3-megagpu-8g machine types.
  • modules/compute/gke-node-pool/versions.tf
    • Updated module_name versions for google and google-beta providers to v1.84.0.
  • modules/compute/resource-policy/versions.tf
    • Updated module_name version to v1.84.0.
  • modules/compute/vm-instance/versions.tf
    • Updated module_name versions for google and google-beta providers to v1.84.0.
  • modules/file-system/cloud-storage-bucket/versions.tf
    • Updated module_name versions for google and google-beta providers to v1.84.0.
  • modules/file-system/filestore/versions.tf
    • Updated module_name versions for google and google-beta providers to v1.84.0.
  • modules/file-system/gke-persistent-volume/versions.tf
    • Updated module_name version to v1.84.0.
  • modules/file-system/gke-storage/versions.tf
    • Updated module_name version to v1.84.0.
  • modules/file-system/managed-lustre/versions.tf
    • Updated module_name versions for google and google-beta providers to v1.84.0.
  • modules/file-system/netapp-storage-pool/versions.tf
    • Updated module_name versions for google and google-beta providers to v1.84.0.
  • modules/file-system/netapp-volume/versions.tf
    • Updated module_name versions for google and google-beta providers to v1.84.0.
  • modules/management/kubectl-apply/versions.tf
    • Updated module_name version to v1.84.0.
  • modules/monitoring/dashboard/versions.tf
    • Updated module_name version to v1.84.0.
  • modules/network/firewall-rules/versions.tf
    • Updated module_name version to v1.84.0.
  • modules/network/pre-existing-subnetwork/versions.tf
    • Updated module_name version to v1.84.0.
  • modules/network/pre-existing-vpc/versions.tf
    • Updated module_name version to v1.84.0.
  • modules/network/private-service-access/versions.tf
    • Updated module_name versions for google and google-beta providers to v1.84.0.
  • modules/scheduler/batch-login-node/versions.tf
    • Updated module_name version to v1.84.0.
  • modules/scheduler/gke-cluster/versions.tf
    • Updated module_name versions for google and google-beta providers to v1.84.0.
  • modules/scheduler/pre-existing-gke-cluster/versions.tf
    • Updated module_name version to v1.84.0.
  • modules/scripts/startup-script/versions.tf
    • Updated module_name version to v1.84.0.
  • pkg/config/expand.go
    • Updated hashicorp/google and hashicorp/google-beta provider versions to <= 7.21.0.
  • pkg/config/expand_test.go
    • Updated expected hashicorp/google and hashicorp/google-beta provider versions in tests.
  • pkg/validators/cloud.go
    • Refactored testMachineTypeInZoneAvailability to use a new generic testResourceInZoneAvailability helper.
    • Added testDiskTypeInZoneAvailability using the new generic helper.
  • pkg/validators/cloud_discovery.go
    • Introduced handleResourceInZoneValidationError for centralized error handling.
    • Updated validateMachineTypeInZone to use handleResourceInZoneValidationError.
    • Added validateDiskTypeInZone function.
  • pkg/validators/validators.go
    • Added testDiskTypeInZone constant and registered testDiskTypeInZoneAvailability validator.
    • Included testDiskTypeInZone in the list of default validators.
  • pkg/validators/validators_test.go
    • Added diskTypeInZone validator to test cases.
    • Updated defaults checks to include the new diskTypeInZone validator.
    • Added TestValidateDiskTypeInZone for the new disk type validator.
  • tools/add_ttl_label.sh
    • Added a new script to add or update a time-to-live label in blueprint YAML files.
  • tools/cleanup.sh
    • Added logic to protect networks used by excluded Managed Lustre instances.
    • Implemented processing and cleanup for Managed Lustre instances based on creation time and exclusion labels.
  • tools/cloud-build/daily-tests/blueprints/crd-default.yaml
    • Added a vars block with deployment_name.
  • tools/cloud-build/daily-tests/blueprints/crd-ubuntu.yaml
    • Added a vars block with deployment_name.
  • tools/cloud-build/daily-tests/builds/ansible-vm.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/batch-mpi.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/chrome-remote-desktop-ubuntu.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/chrome-remote-desktop.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/cloud-batch.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/e2e.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gcluster-dockerfile.yaml
    • Added a step to modify the blueprint with add_ttl_label.sh.
  • tools/cloud-build/daily-tests/builds/gke-a2-highgpu-kueue-onspot.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-a2-highgpu-kueue.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-a3-highgpu-onspot.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-a3-highgpu.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-a3-megagpu-onspot.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-a3-megagpu.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-a3-ultragpu-onspot.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-a3-ultragpu.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-a4-onspot.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-a4.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-a4x.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-g4.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-h4d-onspot.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-h4d.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-inactive-reservation.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-managed-hyperdisk.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-managed-lustre.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-storage.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-tpu-7x.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-tpu-v6e-flex.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke-tpu-v6e.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/gke.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/h4d-vm.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/hcls.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/hpc-build-slurm-image.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/hpc-enterprise-slurm.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/htc-slurm.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/htcondor.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-a3-highgpu-onspot-slurm.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-a3-highgpu-slurm.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-a3-megagpu-onspot-slurm-ubuntu.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-a3-megagpu-slurm-ubuntu.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-a3-ultragpu-custom-blueprint-test.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-a3-ultragpu-onspot-jbvms.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-a3-ultragpu-onspot-slurm.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-a4-highgpu-onspot-slurm.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/monitoring.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/netapp-volumes.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/packer.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/pfs-managed-lustre-slurm.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/pfs-managed-lustre-vm.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-flex.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-debian.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-reconfig-size.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to blueprints used in the test.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-rocky8.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-simple-job-completion.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-ssd.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-startup-scripts.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-static.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-topology.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-tpu.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-ubuntu.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gke.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/cloud-build/daily-tests/builds/spack-gromacs.yaml
    • Integrated tools/add_ttl_label.sh to add TTL labels to the blueprint.
  • tools/publish_release.sh
    • Added a new script to publish release manifests to GCS.
  • tools/validate_configs/golden_copies/expectations/igc_pkr/.ghpc/artifacts/expanded_blueprint.yaml
    • Updated hashicorp/google and hashicorp/google-beta provider versions to <= 7.21.0.
  • tools/validate_configs/golden_copies/expectations/igc_pkr/zero/versions.tf
    • Updated hashicorp/google and hashicorp/google-beta provider versions to <= 7.21.0.
  • tools/validate_configs/golden_copies/expectations/igc_tf/.ghpc/artifacts/expanded_blueprint.yaml
    • Updated hashicorp/google and hashicorp/google-beta provider versions to <= 7.21.0.
  • tools/validate_configs/golden_copies/expectations/igc_tf/one/versions.tf
    • Updated hashicorp/google and hashicorp/google-beta provider versions to <= 7.21.0.
  • tools/validate_configs/golden_copies/expectations/igc_tf/zero/versions.tf
    • Updated hashicorp/google and hashicorp/google-beta provider versions to <= 7.21.0.
  • tools/validate_configs/golden_copies/expectations/merge_flatten/.ghpc/artifacts/expanded_blueprint.yaml
    • Updated hashicorp/google and hashicorp/google-beta provider versions to <= 7.21.0.
  • tools/validate_configs/golden_copies/expectations/merge_flatten/zero/versions.tf
    • Updated hashicorp/google and hashicorp/google-beta provider versions to <= 7.21.0.
  • tools/validate_configs/golden_copies/expectations/versioned_blueprint/.ghpc/artifacts/expanded_blueprint.yaml
    • Updated hashicorp/google and hashicorp/google-beta provider versions to <= 7.21.0.
  • tools/validate_configs/golden_copies/expectations/versioned_blueprint/primary/versions.tf
    • Updated hashicorp/google and hashicorp/google-beta provider versions to <= 7.21.0.
  • tools/validate_configs/validate_configs.sh
    • Added test_disk_type_in_zone to the list of validators to skip during configuration validation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares for the v1.84.0 release, updating versions across modules and Go dependencies. A significant concern is a potential JSON injection vulnerability in the tools/publish_release.sh script, where user-controlled variables are interpolated into a JSON manifest without proper escaping. Other components, including Go validators and other Bash scripts, were found to follow secure coding practices.

Comment thread tools/publish_release.sh
@siddhartha-quad siddhartha-quad marked this pull request as ready for review March 12, 2026 09:52
@siddhartha-quad siddhartha-quad requested review from a team and samskillman as code owners March 12, 2026 09:52
@siddhartha-quad siddhartha-quad merged commit a0c28df into main Mar 12, 2026
79 of 89 checks passed
@siddhartha-quad siddhartha-quad deleted the release-candidate branch March 13, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants