Skip to content

Add ttl label to Core HPC Infrastructure & Operational Blueprints#5293

Merged
saara-tyagi27 merged 3 commits into
GoogleCloudPlatform:developfrom
saara-tyagi27:add-labels-hpc
Mar 9, 2026
Merged

Add ttl label to Core HPC Infrastructure & Operational Blueprints#5293
saara-tyagi27 merged 3 commits into
GoogleCloudPlatform:developfrom
saara-tyagi27:add-labels-hpc

Conversation

@saara-tyagi27

@saara-tyagi27 saara-tyagi27 commented Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Add ttl label to core HPC Infrastructure & Operational Blueprints

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist

gemini-code-assist Bot commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @saara-tyagi27, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial enhancement to the daily Cloud Build test suite by implementing automatic Time-To-Live (TTL) labeling for resources created during these tests. The primary goal is to prevent the accumulation of orphaned cloud resources and optimize cost management by ensuring that test environments are automatically deprovisioned after their intended lifespan. This change standardizes the cleanup process across numerous HPC blueprints.

Highlights

  • Automated Resource Cleanup: Integrated a ttl labeling script into various daily Cloud Build test workflows to ensure resources provisioned during tests are automatically cleaned up.
  • Blueprint Labeling: Applied ttl labels to a wide range of HPC infrastructure and operational blueprints, including different Slurm configurations, HCLS, HTCondor, and storage solutions.
Changelog
  • tools/cloud-build/daily-tests/builds/h4d-vm.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the h4d-vm blueprint.
  • tools/cloud-build/daily-tests/builds/hcls.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the hcls-blueprint.yaml.
  • tools/cloud-build/daily-tests/builds/hpc-build-slurm-image.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the hpc-build-slurm-image.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/hpc-enterprise-slurm.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the hpc-enterprise-slurm.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/htc-slurm.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the htc-slurm.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/htcondor.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the htc-htcondor.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/monitoring.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the monitoring.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/netapp-volumes.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the netapp-volumes.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/ofe-deployment.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the netapp-volumes.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/packer.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the image-builder.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/pfs-managed-lustre-slurm.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the pfs-managed-lustre-slurm.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/pfs-managed-lustre-vm.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the pfs-managed-lustre-vm.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-flex.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the slurm-flex.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-debian.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the hpc-slurm-ubuntu2204.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-reconfig-size.yaml
    • Added BP_BEFORE and BP_AFTER variables and executed add_ttl_label.sh script for both blueprints.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-rocky8.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the hpc-slurm.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-simple-job-completion.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the slurm-simple.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-ssd.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the hpc-slurm-local-ssd.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-startup-scripts.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the slurm-gcp-v6-startup-scripts.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-static.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the hpc-slurm-static.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-topology.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the topology-test.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-tpu.yaml
    • Executed add_ttl_label.sh script for the hpc-slurm6-tpu.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gcp-v6-ubuntu.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the hpc-slurm-ubuntu2204.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/slurm-gke.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the slurm-gke.yaml blueprint.
  • tools/cloud-build/daily-tests/builds/spack-gromacs.yaml
    • Added BLUEPRINT variable and executed add_ttl_label.sh script for the hpc-slurm-gromacs.yaml blueprint.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 26, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a time-to-live label to various test blueprints to aid in resource cleanup. The changes are mostly correct, but there are a few issues. Some test configurations use incorrect or mismatched blueprint files, which could be copy-paste errors. Additionally, a couple of python-based integration tests are not using the modified blueprints because they are called with hardcoded file paths instead of the variable containing the path to the modified file. These issues have been highlighted with specific comments and suggestions, emphasizing consistency with existing test modification patterns where applicable.

Comment thread tools/cloud-build/daily-tests/builds/slurm-flex.yaml Outdated
Comment thread tools/cloud-build/daily-tests/builds/slurm-gcp-v6-debian.yaml
Comment thread tools/cloud-build/daily-tests/builds/slurm-gcp-v6-simple-job-completion.yaml Outdated
Comment thread tools/cloud-build/daily-tests/builds/ofe-deployment.yaml Outdated
@saara-tyagi27 saara-tyagi27 requested a review from LAVEEN March 2, 2026 07:47
@saara-tyagi27 saara-tyagi27 marked this pull request as ready for review March 2, 2026 07:48
@saara-tyagi27 saara-tyagi27 requested review from a team and samskillman as code owners March 2, 2026 07:48
@saara-tyagi27 saara-tyagi27 added the release-chore To not include into release notes label Mar 2, 2026
@saara-tyagi27

saara-tyagi27 commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

The pr has been tested in the following way:

When the resources were deployed, they were observed to have the correct time-to-live label.

@saara-tyagi27 saara-tyagi27 merged commit a755ad6 into GoogleCloudPlatform:develop Mar 9, 2026
25 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LAVEEN LAVEEN LAVEEN approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saara-tyagi27 @LAVEEN